Bug 164572 – REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Ryan Haddad]

LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r208501%20(10931)/results.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-actual.txt
@@ -16,9 +16,9 @@
 scroll event (delta 10 0, phase 'changed')
 didBeginSwipe
 swipe event (delta 1 0, phase 'changed')
+willEndSwipe
 swipe event (delta 256 0, phase 'changed')
 swipe event (delta 0 0, phase 'ended')
-willEndSwipe
-didEndSwipe
 didRemoveSwipeSnapshot
+Failure. The swipe should have navigated back to the first page. (expected: true, actual: false)

[Ryan Haddad]

Seeing this on El Capitan Release WK2

[Ryan Haddad]

Marked as failing on El Capitan in http://trac.webkit.org/projects/webkit/changeset/208566

[Alexey Proskuryakov]

Test history suggests that this started with http://trac.webkit.org/r208455

The tests sometimes passes on retry, and sometimes fails again.

[Alexey Proskuryakov]

Reproduces locally with this command:

run-webkit-tests swipe/basic-cached-back-swipe.html swipe/pushState-cached-back-swipe.html

[Alexey Proskuryakov]

Created attachment 294997 [details]
proposed fix

[WebKit Commit Bot]

Comment on attachment 294997 [details]
proposed fix

Clearing flags on attachment: 294997

Committed r208831: <http://trac.webkit.org/changeset/208831>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 294997 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=294997&action=review

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:107
> +    while ([NSApp nextEventMatchingMask:NSEventMaskGesture | NSEventMaskScrollWheel untilDate:nil inMode:NSDefaultRunLoopMode dequeue:YES]) {

Oops. Sorry about that!