WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164494
[Mac] Stop using deprecated AppKit enumeration values
https://bugs.webkit.org/show_bug.cgi?id=164494
Summary
[Mac] Stop using deprecated AppKit enumeration values
Chris Dumez
Reported
2016-11-07 16:20:31 PST
Stop using deprecated AppKit enumeration values.
Attachments
Patch
(155.29 KB, patch)
2016-11-07 16:31 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.30 KB, patch)
2016-11-07 16:36 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.36 KB, patch)
2016-11-07 17:02 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.10 KB, patch)
2016-11-07 18:34 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.32 KB, patch)
2016-11-07 18:38 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.28 KB, patch)
2016-11-07 19:01 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.29 KB, patch)
2016-11-07 19:06 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(155.24 KB, patch)
2016-11-07 19:11 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(159.37 KB, patch)
2016-11-07 19:22 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(159.43 KB, patch)
2016-11-07 19:26 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(159.51 KB, patch)
2016-11-07 19:39 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(165.31 KB, patch)
2016-11-07 20:12 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(231.27 KB, patch)
2016-11-07 21:06 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(231.27 KB, patch)
2016-11-07 21:30 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(230.44 KB, patch)
2016-11-07 21:43 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(225.88 KB, patch)
2016-11-08 09:21 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(225.85 KB, patch)
2016-11-08 09:56 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(225.73 KB, patch)
2016-11-09 10:18 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(17)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-11-07 16:31:30 PST
Created
attachment 294099
[details]
Patch
WebKit Commit Bot
Comment 2
2016-11-07 16:32:58 PST
Attachment 294099
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3
2016-11-07 16:36:04 PST
Created
attachment 294100
[details]
Patch
WebKit Commit Bot
Comment 4
2016-11-07 16:38:05 PST
Attachment 294100
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5
2016-11-07 17:02:30 PST
Created
attachment 294102
[details]
Patch
WebKit Commit Bot
Comment 6
2016-11-07 17:10:10 PST
Attachment 294102
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 7
2016-11-07 18:34:58 PST
Created
attachment 294111
[details]
Patch
WebKit Commit Bot
Comment 8
2016-11-07 18:38:03 PST
Attachment 294111
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 9
2016-11-07 18:38:38 PST
Created
attachment 294112
[details]
Patch
WebKit Commit Bot
Comment 10
2016-11-07 18:40:59 PST
Attachment 294112
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 11
2016-11-07 19:01:37 PST
Created
attachment 294117
[details]
Patch
WebKit Commit Bot
Comment 12
2016-11-07 19:05:04 PST
Attachment 294117
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 13
2016-11-07 19:06:38 PST
Created
attachment 294118
[details]
Patch
WebKit Commit Bot
Comment 14
2016-11-07 19:10:05 PST
Attachment 294118
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 15
2016-11-07 19:11:47 PST
Created
attachment 294119
[details]
Patch
WebKit Commit Bot
Comment 16
2016-11-07 19:13:13 PST
Attachment 294119
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 17
2016-11-07 19:22:42 PST
Created
attachment 294121
[details]
Patch
WebKit Commit Bot
Comment 18
2016-11-07 19:25:30 PST
Attachment 294121
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 19
2016-11-07 19:26:07 PST
Created
attachment 294123
[details]
Patch
WebKit Commit Bot
Comment 20
2016-11-07 19:27:20 PST
Attachment 294123
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 21
2016-11-07 19:39:52 PST
Created
attachment 294125
[details]
Patch
WebKit Commit Bot
Comment 22
2016-11-07 19:41:35 PST
Attachment 294125
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 23
2016-11-07 20:12:25 PST
Created
attachment 294128
[details]
Patch
WebKit Commit Bot
Comment 24
2016-11-07 20:14:41 PST
Attachment 294128
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 25
2016-11-07 21:06:59 PST
Created
attachment 294130
[details]
Patch
WebKit Commit Bot
Comment 26
2016-11-07 21:08:56 PST
Attachment 294130
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 27
2016-11-07 21:30:32 PST
Created
attachment 294132
[details]
Patch
WebKit Commit Bot
Comment 28
2016-11-07 21:33:08 PST
Attachment 294132
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 29
2016-11-07 21:43:02 PST
Created
attachment 294133
[details]
Patch
WebKit Commit Bot
Comment 30
2016-11-07 21:46:15 PST
Attachment 294133
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:471: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:610: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 72 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 31
2016-11-07 22:42:43 PST
Comment on
attachment 294133
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294133&action=review
> Source/WebCore/editing/cocoa/HTMLConverter.mm:70
I suggest doing this in WebCorePrefix.h the way we do in WebKit2Prefix.h instead of doing it each file where it is needed.
Chris Dumez
Comment 32
2016-11-08 09:21:28 PST
Created
attachment 294164
[details]
Patch
WebKit Commit Bot
Comment 33
2016-11-08 09:23:04 PST
Attachment 294164
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 34
2016-11-08 09:56:11 PST
Created
attachment 294167
[details]
Patch
WebKit Commit Bot
Comment 35
2016-11-08 09:58:10 PST
Attachment 294167
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 36
2016-11-09 10:18:53 PST
Created
attachment 294235
[details]
Patch
WebKit Commit Bot
Comment 37
2016-11-09 10:20:13 PST
Attachment 294235
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:193: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:68: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebNSViewExtras.m:96: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:470: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/mac/EventHandlerMac.mm:612: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 38
2016-11-09 11:35:01 PST
Comment on
attachment 294235
[details]
Patch Clearing flags on attachment: 294235 Committed
r208455
: <
http://trac.webkit.org/changeset/208455
>
WebKit Commit Bot
Comment 39
2016-11-09 11:35:07 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 40
2016-11-16 17:02:03 PST
This caused
bug 164572
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug