Bug 164530 - Allow HTTP 0.9 loads for requests to default ports
Summary: Allow HTTP 0.9 loads for requests to default ports
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 158589
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-08 15:47 PST by Daniel Bates
Modified: 2016-11-15 09:01 PST (History)
6 users (show)

See Also:


Attachments
Patch and layout test (12.12 KB, patch)
2016-11-08 16:12 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-11-08 15:47:12 PST
Following the fix for bug #158589 we no longer load HTTP 0.9 resources. This policy is too stringent and prevents loading Shoutcast/Icecast streams served over default ports. For compatibility we should allow Shoutcast/Icecast streams served over default ports.
Comment 1 Daniel Bates 2016-11-08 15:47:46 PST
<rdar://problem/29167064>
Comment 2 Daniel Bates 2016-11-08 16:00:23 PST
(In reply to comment #0)
> Following the fix for bug #158589 we no longer load HTTP 0.9 resources. This
> policy is too stringent and prevents loading Shoutcast/Icecast streams
> served over default ports. For compatibility we should allow
> Shoutcast/Icecast streams served over default ports.

Actually, this bug does not need to be specific to Shoutcast/Icecast streams. Instead this bug should be about allowing HTTP 0.9 loads for requests to default ports. This will allow loading Shoutcast/Icecast streams over default ports among other benefits.
Comment 3 Daniel Bates 2016-11-08 16:12:03 PST
Created attachment 294200 [details]
Patch and layout test

This patch modifies the test results added in the patch for bug #164389 and bug #164387. It also adds a new test to the directory added in the patch for bug #164389. Neither the patch for bug #164389 nor bug #164387 has landed as of the time of writing.
Comment 4 Alexey Proskuryakov 2016-11-08 16:54:13 PST
Comment on attachment 294200 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=294200&action=review

> Source/WebCore/ChangeLog:10
> +        loading from a Shoutcast/Icecast server on a default port among other benefits.

This is not the right fix for shoutcast streams, which are normally served over weird ports. So, I do not see why this change is desirable.
Comment 5 Alexey Proskuryakov 2016-11-08 16:56:15 PST
I think that the right fix for shoutcast would be to check the protocol in response.
Comment 6 Daniel Bates 2016-11-08 23:07:25 PST
(In reply to comment #4)
> Comment on attachment 294200 [details]
> Patch and layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294200&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        loading from a Shoutcast/Icecast server on a default port among other benefits.
> 
> This is not the right fix for shoutcast streams, which are normally served
> over weird ports. So, I do not see why this change is desirable.

I take it you feel that there is little compatibility risk to blocking subresources served with an HTTP 0.9 response?
Comment 7 Leo A 2016-11-09 08:54:10 PST
The proposed solution doesn't go far enough. Shoutcast is often run on non-standard ports because older versions of Shoutcast (Shoutcast 1, of which there are hundreds of thousands of instances) can only run multiple internet radio stations from the name IP address by placing them on separate ports. 

The fix MUST be to allow any Shoutcast/Icecast stream on any port however specified. Anything less than this, would not be an acceptable resolution to the bug.
Comment 8 Alexey Proskuryakov 2016-11-09 09:31:31 PST
> I take it you feel that there is little compatibility risk to blocking subresources served with an HTTP 0.9 response?

As of now, the ChangeLog claims that this "will allow loading from a Shoutcast/Icecast server on a default port among other benefits."

What I'm saying is that this won't help Shoutcast/Icecast in practice, and that I don't know what the other benefits are. I haven't seen any bug reports about other issues, but if there are any, please explain those in ChangeLog (and please also take out mentions of SHOUTcast).
Comment 9 Daniel Bates 2016-11-15 09:01:44 PST
(In reply to comment #7)
> The proposed solution doesn't go far enough. Shoutcast is often run on
> non-standard ports because older versions of Shoutcast (Shoutcast 1, of
> which there are hundreds of thousands of instances) can only run multiple
> internet radio stations from the name IP address by placing them on separate
> ports. 
> 
> The fix MUST be to allow any Shoutcast/Icecast stream on any port however
> specified. Anything less than this, would not be an acceptable resolution to
> the bug.

You're right! We'll fix this in <rdar://problem/28734311>.