Bug 164475 - [EFL] Suppress build warning in generated Geoclue2Interface.c
Summary: [EFL] Suppress build warning in generated Geoclue2Interface.c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 159128
  Show dependency tree / graph
 
Reported: 2016-11-07 04:50 PST by Csaba Osztrogonác
Modified: 2016-11-14 04:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2016-11-07 04:51 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-11-07 04:50:36 PST 
https://trac.webkit.org/changeset/202479 disabled werror for this file,
but I think this noisy build output isn't good, let's suppress this warning.

[1270/5284] Building C object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/Geoclue2Interface.c.o
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client':
DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent':
DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start':
DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop':
DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter]

It turned out, GTK already suppresses this warning:
https://bugs.webkit.org/show_bug.cgi?id=163733#c3
Comment 1 Csaba Osztrogonác 2016-11-07 04:51:37 PST 
Created attachment 294054 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-14 04:25:32 PST 
Comment on attachment 294054 [details]
Patch

Clearing flags on attachment: 294054

Committed r208677: <http://trac.webkit.org/changeset/208677>
Comment 3 WebKit Commit Bot 2016-11-14 04:25:37 PST 
All reviewed patches have been landed.  Closing bug.