Bug 159128 - [EFL] Fix build warning when using geoclue2
Summary: [EFL] Fix build warning when using geoclue2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 164475
Blocks: 159123
  Show dependency tree / graph
 
Reported: 2016-06-26 18:54 PDT by Gyuyoung Kim
Modified: 2016-11-07 04:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2016-06-26 19:13 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-06-26 18:54:33 PDT 
There is build warnings which are handled as build error on EFL port. This warning influences on debian EFL build.

DerivedSources/WebCore/Geoclue2Interface.c:673:21: error: unused parameter ‘object’ [-Werror=unused-parameter]
     GeoclueManager *object,
                     ^
DerivedSources/WebCore/Geoclue2Interface.c: In function ‘geoclue_manager_complete_add_agent’:
DerivedSources/WebCore/Geoclue2Interface.c:693:21: error: unused parameter ‘object’ [-Werror=unused-parameter]
     GeoclueManager *object,
                     ^
DerivedSources/WebCore/Geoclue2Interface.c: In function ‘geoclue_client_complete_start’:
DerivedSources/WebCore/Geoclue2Interface.c:2373:20: error: unused parameter ‘object’ [-Werror=unused-parameter]
     GeoclueClient *object,
                    ^
DerivedSources/WebCore/Geoclue2Interface.c: In function ‘geoclue_client_complete_stop’:
DerivedSources/WebCore/Geoclue2Interface.c:2391:20: error: unused parameter ‘object’ [-Werror=unused-parameter]
     GeoclueClient *object,
                    ^
cc1: all warnings being treated as errors
[1966/5699] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSMutationObserver.cpp.o
ninja: build stopped: subcommand failed.
Comment 1 Gyuyoung Kim 2016-06-26 19:13:09 PDT 
Created attachment 282100 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-26 22:10:22 PDT 
Comment on attachment 282100 [details]
Patch

Clearing flags on attachment: 282100

Committed r202479: <http://trac.webkit.org/changeset/202479>
Comment 3 WebKit Commit Bot 2016-06-26 22:10:26 PDT 
All reviewed patches have been landed.  Closing bug.