WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164396
Add an assertion to diagnose stress GC bots test failures
https://bugs.webkit.org/show_bug.cgi?id=164396
Summary
Add an assertion to diagnose stress GC bots test failures
Ryosuke Niwa
Reported
2016-11-03 19:39:02 PDT
Somehow we're hitting an assertion in ElementQueue::invokeAll. As far as I understand, this assertion should only fire when ElementQueue::add is called while we're inside invokeAll. Add an assertion to figure out where this is happening because I can't reproduce locally. <
rdar://problem/28945851
>
Attachments
Adds an assertion
(2.39 KB, patch)
2016-11-03 19:52 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.36 KB, patch)
2016-11-03 20:01 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-11-03 19:52:27 PDT
Created
attachment 293847
[details]
Adds an assertion
Antti Koivisto
Comment 2
2016-11-03 19:55:14 PDT
Comment on
attachment 293847
[details]
Adds an assertion View in context:
https://bugs.webkit.org/attachment.cgi?id=293847&action=review
> Source/WebCore/dom/CustomElementReactionQueue.cpp:210 > +#if !ASSERT_DISABLED > + ASSERT(!m_invoking); > +#endif
Don't need ASSERT_DISABLED test here.
Ryosuke Niwa
Comment 3
2016-11-03 20:01:39 PDT
Created
attachment 293848
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2016-11-03 20:49:27 PDT
The commit-queue encountered the following flaky tests while processing
attachment 293848
[details]
: inspector/sampling-profiler/call-frame-with-dom-functions.html
bug 164399
(author:
sbarati@apple.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5
2016-11-03 20:49:50 PDT
Comment on
attachment 293848
[details]
Patch for landing Clearing flags on attachment: 293848 Committed
r208366
: <
http://trac.webkit.org/changeset/208366
>
WebKit Commit Bot
Comment 6
2016-11-03 20:49:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug