Bug 164396 - Add an assertion to diagnose stress GC bots test failures
Summary: Add an assertion to diagnose stress GC bots test failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 154907
  Show dependency tree / graph
 
Reported: 2016-11-03 19:39 PDT by Ryosuke Niwa
Modified: 2016-11-03 20:49 PDT (History)
5 users (show)

See Also:

Attachments
Adds an assertion (2.39 KB, patch)
2016-11-03 19:52 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (2.36 KB, patch)
2016-11-03 20:01 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-11-03 19:39:02 PDT 
Somehow we're hitting an assertion in ElementQueue::invokeAll.
As far as I understand, this assertion should only fire when ElementQueue::add is called while we're inside invokeAll.
Add an assertion to figure out where this is happening because I can't reproduce locally.

<rdar://problem/28945851>
Comment 1 Ryosuke Niwa 2016-11-03 19:52:27 PDT 
Created attachment 293847 [details]
Adds an assertion
Comment 2 Antti Koivisto 2016-11-03 19:55:14 PDT 
Comment on attachment 293847 [details]
Adds an assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=293847&action=review

> Source/WebCore/dom/CustomElementReactionQueue.cpp:210
> +#if !ASSERT_DISABLED
> +    ASSERT(!m_invoking);
> +#endif

Don't need ASSERT_DISABLED test here.
Comment 3 Ryosuke Niwa 2016-11-03 20:01:39 PDT 
Created attachment 293848 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-11-03 20:49:27 PDT 
The commit-queue encountered the following flaky tests while processing attachment 293848 [details]:

inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: sbarati@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2016-11-03 20:49:50 PDT 
Comment on attachment 293848 [details]
Patch for landing

Clearing flags on attachment: 293848

Committed r208366: <http://trac.webkit.org/changeset/208366>
Comment 6 WebKit Commit Bot 2016-11-03 20:49:55 PDT 
All reviewed patches have been landed.  Closing bug.