Bug 164396 – Add an assertion to diagnose stress GC bots test failures

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Somehow we're hitting an assertion in ElementQueue::invokeAll.
As far as I understand, this assertion should only fire when ElementQueue::add is called while we're inside invokeAll.
Add an assertion to figure out where this is happening because I can't reproduce locally.

<rdar://problem/28945851>

[Ryosuke Niwa]

Created attachment 293847 [details]
Adds an assertion

[Antti Koivisto]

Comment on attachment 293847 [details]
Adds an assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=293847&action=review

> Source/WebCore/dom/CustomElementReactionQueue.cpp:210
> +#if !ASSERT_DISABLED
> +    ASSERT(!m_invoking);
> +#endif

Don't need ASSERT_DISABLED test here.

[Ryosuke Niwa]

Created attachment 293848 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 293848 [details]:

inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 293848 [details]
Patch for landing

Clearing flags on attachment: 293848

Committed r208366: <http://trac.webkit.org/changeset/208366>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.