Bug 164311 - REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding
Summary: REGRESSION (r199558): File paths selected for upload are stored using the wro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
: 166473 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-01 19:26 PDT by Andy Estes
Modified: 2017-06-05 09:32 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2016-11-02 10:22 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2016-11-02 11:20 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-11-01 19:26:05 PDT
REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding
Comment 1 Andy Estes 2016-11-01 19:27:07 PDT
<rdar://problem/26995374>
Comment 2 Andy Estes 2016-11-02 10:22:06 PDT
Created attachment 293669 [details]
Patch
Comment 3 Tim Horton 2016-11-02 11:09:26 PDT
Comment on attachment 293669 [details]
Patch

This seems like one of those mistakes we've probably made in other places; should we look around and fix others?
Comment 4 Andy Estes 2016-11-02 11:12:50 PDT
(In reply to comment #3)
> Comment on attachment 293669 [details]
> Patch
> 
> This seems like one of those mistakes we've probably made in other places;
> should we look around and fix others?

Yeah, we should. I filed https://bugs.webkit.org/show_bug.cgi?id=164330 about this.
Comment 5 Andy Estes 2016-11-02 11:20:03 PDT
Created attachment 293679 [details]
Patch
Comment 6 WebKit Commit Bot 2016-11-02 11:55:36 PDT
Comment on attachment 293679 [details]
Patch

Clearing flags on attachment: 293679

Committed r208295: <http://trac.webkit.org/changeset/208295>
Comment 7 WebKit Commit Bot 2016-11-02 11:55:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2016-11-05 15:42:38 PDT
Comment on attachment 293669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293669&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:345
> -        filenames.uncheckedAppend(fileURL.fileSystemRepresentation);
> +        filenames.uncheckedAppend(String::fromUTF8(fileURL.fileSystemRepresentation));

Instead of:

    String::fromUTF8(fileURL.fileSystemRepresentation)

I believe we can, and should, just use:

    fileURL.path
Comment 9 Andy Estes 2017-01-09 12:56:54 PST
*** Bug 166473 has been marked as a duplicate of this bug. ***