Bug 164256 - [WebIDL] Move interfaces and typed arrays over to JSDOMConvert
Summary: [WebIDL] Move interfaces and typed arrays over to JSDOMConvert
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 17:10 PDT by Sam Weinig
Modified: 2016-11-04 13:55 PDT (History)
8 users (show)

See Also:

Attachments
Patch (109.06 KB, patch)
2016-10-31 17:12 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (1.95 MB, application/zip)
2016-10-31 18:47 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.90 MB, application/zip)
2016-10-31 18:47 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (1.31 MB, application/zip)
2016-10-31 18:59 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted)
2016-10-31 19:06 PDT, Build Bot 		no flags Details
Patch (132.45 KB, patch)
2016-11-01 12:14 PDT, Sam Weinig 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-10-31 17:10:06 PDT 
[WebIDL] Move interfaces and typed arrays over to JSDOMConvert
Comment 1 Sam Weinig 2016-10-31 17:12:49 PDT 
Created attachment 293500 [details]
Patch

For EWS
Comment 2 WebKit Commit Bot 2016-10-31 17:14:32 PDT 
Attachment 293500 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:191:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2016-10-31 18:47:40 PDT 
Comment on attachment 293500 [details]
Patch

Attachment 293500 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2417704

New failing tests:
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGTransformList.html
svg/custom/polyline-points-crash.html
svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGLengthList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml
Comment 4 Build Bot 2016-10-31 18:47:43 PDT 
Created attachment 293510 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-10-31 18:47:46 PDT 
Comment on attachment 293500 [details]
Patch

Attachment 293500 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2417748

New failing tests:
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGTransformList.html
svg/custom/polyline-points-crash.html
svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGLengthList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml
Comment 6 Build Bot 2016-10-31 18:47:49 PDT 
Created attachment 293511 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-10-31 18:59:50 PDT 
Comment on attachment 293500 [details]
Patch

Attachment 293500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2417898

New failing tests:
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGTransformList.html
svg/custom/polyline-points-crash.html
svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGLengthList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml
Comment 8 Build Bot 2016-10-31 18:59:55 PDT 
Created attachment 293512 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-10-31 19:06:45 PDT 
Comment on attachment 293500 [details]
Patch

Attachment 293500 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2417840

New failing tests:
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGTransformList.html
svg/custom/polyline-points-crash.html
svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGLengthList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml
Comment 10 Build Bot 2016-10-31 19:06:54 PDT 
Created attachment 293513 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Sam Weinig 2016-11-01 12:14:26 PDT 
Created attachment 293565 [details]
Patch
Comment 12 WebKit Commit Bot 2016-11-01 12:17:01 PDT 
Attachment 293565 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:191:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Sam Weinig 2016-11-02 15:18:11 PDT 
Committed r208308: <http://trac.webkit.org/changeset/208308>