RESOLVED FIXED 164205
[GTK] Remove support for geoclue1 
https://bugs.webkit.org/show_bug.cgi?id=164205
Summary [GTK] Remove support for geoclue1
Michael Catanzaro
Reported 2016-10-30 08:46:58 PDT
Bug #164170 is correct, but adds an unnecessary runtime dependency on libgeoclue when built with geoclue2. Previously, we were conditionally linked to libgeoclue only if using geoclue1, because the pkg-config name in the FindGeoclue2 module was wrong, pointing to the .pc file that provides no cflags or ldflags for the library, only a couple pkg-config variables for finding the D-Bus service. So the GEOCLUE_LIBRARIES CMake variable was previously (incorrectly) empty, and that worked because we don't actually use the library, only the D-Bus interface. Although Ubuntu has until recently been building WebKit with geoclue1, it actually has had support for geoclue2 for years, so we don't need to keep the obsolete geoclue1 stuff around anymore. Removing geoclue1 support means we can get rid of the cruft for linking to libgeoclue.
Attachments
Patch (31.85 KB, patch)
2017-08-09 14:13 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-10-30 10:48:09 PDT
So I'm wrong, GEOCLUE2_LIBRARIES and GEOCLUE2_INCLUDE_DIRS are separate CMake variables from the Geoclue1 versions, so there's no unnecessary dependency and no particular reason to drive removing Geoclue1 support. We should do it eventually anyway, so I'll leave this bug open.
Michael Catanzaro
Comment 2 2017-08-09 14:13:06 PDT
Created attachment 317740 [details] Patch
WebKit Commit Bot
Comment 3 2017-08-09 22:58:29 PDT
Comment on attachment 317740 [details] Patch Clearing flags on attachment: 317740 Committed r220515: <http://trac.webkit.org/changeset/220515>
WebKit Commit Bot
Comment 4 2017-08-09 22:58:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.