Bug 164170 – [GTK] Build break by missing geoclue-2.0.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Hyowon Kim]

I got the following build error on my initial build for WebkitGTK.

-- Checking for module 'geoclue-2.0'
--   No package 'geoclue-2.0' found
-- Could NOT find GEOCLUE2 (missing:  VERSION_OK) 
-- Checking for module 'geoclue'
--   No package 'geoclue' found
-- Could NOT find GEOCLUE (missing:  GEOCLUE_INCLUDE_DIRS GEOCLUE_LIBRARIES) 
CMake Error at Source/cmake/OptionsGTK.cmake:253 (message):
  Geoclue is needed for ENABLE_GEOLOCATION.
Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:47 (include)
  CMakeLists.txt:137 (include)

[Hyowon Kim]

Created attachment 293266 [details]
Patch

[Michael Catanzaro]

Comment on attachment 293266 [details]
Patch

But we do have this function:

        $(aptIfElse libgeoclue-2-dev libgeoclue-dev) \

I guess it is broken for you for some reason, can you debug it?

The pkg-config file should be in the -dev package, so there's no value in installing the base package explicitly.

[Hyowon Kim]

Created attachment 293345 [details]
Patch

[Hyowon Kim]

(In reply to comment #2)
> Comment on attachment 293266 [details]
> Patch
> 
> But we do have this function:
> 
>         $(aptIfElse libgeoclue-2-dev libgeoclue-dev) \
> 
> I guess it is broken for you for some reason, can you debug it?
> 
> The pkg-config file should be in the -dev package, so there's no value in
> installing the base package explicitly.

It seems the pc file name installed by libgeoclue-2-dev is libgeoclue-2, not geoclue-2.
Is my new patch an appropriate correction?

[Michael Catanzaro]

Comment on attachment 293345 [details]
Patch

Ah, yes! Good catch!

Seems that geoclue-2.0.pc ensures the D-Bus service exists (and it's what we use to find it in PlatformGTK.cmake). libgeoclue-2.0 is for the library and it's indeed what we're supposed to use here.

[Michael Catanzaro]

So the reason it builds at all is simple: we do not actually use libgeoclue. Unfortunately while this commit is clearly correct -- the FindGeoClue2 module was broken -- it does mean we're now going to be unnecessarily linking against libgeoclue. :(

And it's slightly tricky to fix, because we still have code to support geoclue1, and that code really does need to link to (the obsolete) libgeoclue. But we don't need to support geoclue1 anymore, since geoclue2 has been around for a long time. So I think we should remove the geoclue1 support entirely, and then we can also remove this unnecessary find module and stop linking to libgeoclue. I filed bug #164205 for this.

I still give your patch r+, since the Find module was broken and that's what you were fixing.

[WebKit Commit Bot]

Comment on attachment 293345 [details]
Patch

Clearing flags on attachment: 293345

Committed r208127: <http://trac.webkit.org/changeset/208127>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.