Bug 163816 - [Web ID] Overload resolution is wrong if one of the types is a nullable union
Summary: [Web ID] Overload resolution is wrong if one of the types is a nullable union
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 163764
Blocks: 163795
  Show dependency tree / graph
 
Reported: 2016-10-21 16:13 PDT by Chris Dumez
Modified: 2016-10-21 22:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.02 KB, patch)
2016-10-21 17:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-21 16:13:20 PDT 
Overload resolution is wrong if one of the types is a nullable union. This is because we never consider the union type itself, only its subtypes. Therefore, we checks if any of the union's subtypes are nullable but we fail to check if the union itself is nullable.

I noticed this while working on Bug 163795.
Comment 1 Chris Dumez 2016-10-21 17:25:37 PDT 
Created attachment 292438 [details]
Patch
Comment 2 Chris Dumez 2016-10-21 17:29:24 PDT 
Comment on attachment 292438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292438&action=review

> Source/WebCore/bindings/scripts/test/TestObj.idl:311
> +    void overloadWithNullableUnion((TestObj or TestNode)? objectOrNode);

Passing null here would previously call the overload below instead of this one.
Comment 3 WebKit Commit Bot 2016-10-21 22:30:11 PDT 
Comment on attachment 292438 [details]
Patch

Clearing flags on attachment: 292438

Committed r207705: <http://trac.webkit.org/changeset/207705>
Comment 4 WebKit Commit Bot 2016-10-21 22:30:16 PDT 
All reviewed patches have been landed.  Closing bug.