Bug 163795 – WebGLRenderingContextBase.bufferData() should use a union instead of overloading

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

WebGLRenderingContextBase.bufferData() should use a union instead of overloading:
- https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14

[Chris Dumez]

Created attachment 292501 [details]
Patch

[Darin Adler]

Comment on attachment 292501 [details]
Patch

Looks good, but GTK and EFL builds are failing.

[Chris Dumez]

Created attachment 292504 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 292504 [details]
Patch

Clearing flags on attachment: 292504

Committed r207715: <http://trac.webkit.org/changeset/207715>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Filip Pizlo]

Comment on attachment 292504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292504&action=review

> Source/JavaScriptCore/runtime/JSArrayBuffer.h:80
> +inline ArrayBuffer* JSArrayBuffer::toWrapped(JSValue value)
> +{
> +    return toArrayBuffer(value);
> +}
> +

FYI, this method, and its goal of reducing special handling of ArrayBuffer contradicts https://bugs.webkit.org/show_bug.cgi?id=163986 (SharedArrayBuffer), which requires us to increase the special handling of ArrayBuffer.  It's going to be necessary for clients of ArrayBuffer to state at the point of use if they are OK with the buffer being shared so that we don't accidentally use a shared array buffer in a context where it would not be safe to do so.