Bug 163731 – [Modern Media Controls] Media Controller: Placard support

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We need to show the Airplay and picture-in-picture placards when the media is played in Airplay or PiP mode.

[Radar WebKit Bug Importer]

<rdar://problem/28869598>

[Antoine Quint]

Created attachment 292191 [details]
Patch

[Antoine Quint]

Tests aren't ready yet but the source can be reviewed already.

[Antoine Quint]

Created attachment 293448 [details]
Patch

[Build Bot]

Comment on attachment 293448 [details]
Patch

Attachment 293448 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2412841

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-pip.html

[Build Bot]

Created attachment 293453 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293448 [details]
Patch

Attachment 293448 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2413166

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-pip.html

[Build Bot]

Created attachment 293458 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293448 [details]
Patch

Attachment 293448 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2413203

New failing tests:
media/modern-media-controls/airplay-placard/airplay-placard.html
media/modern-media-controls/placard-support/placard-support-airplay.html
media/modern-media-controls/placard-support/placard-support-pip.html

[Build Bot]

Created attachment 293461 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

https://trac.webkit.org/changeset/208182

[Ryan Haddad]

Both of the tests added with this change time out on macOS Release:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r208182%20(1189)/results.html

[Ryan Haddad]

Reverted r208182 for reason:

Both of the tests added with this change time out on macOS Release.

Committed r208195: <http://trac.webkit.org/changeset/208195>

[Ryan Haddad]

(In reply to comment #7)
> Comment on attachment 293448 [details]
> Patch
> 
> Attachment 293448 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/2413166
> 
> New failing tests:
> media/modern-media-controls/airplay-placard/airplay-placard.html
> media/modern-media-controls/placard-support/placard-support-airplay.html
> media/modern-media-controls/placard-support/placard-support-pip.html

It looks like EWS predicted this before the patch was landed.

[Antoine Quint]

Created attachment 293564 [details]
Patch

[Antoine Quint]

Created attachment 293586 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293586 [details]
Patch for landing

Rejecting attachment 293586 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 293586, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing file LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html
patching file LayoutTests/platform/ios-simulator/TestExpectations
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1195.
Hunk #2 succeeded at 1451 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2445831

[Antoine Quint]

Created attachment 293593 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293593 [details]
Patch for landing

Clearing flags on attachment: 293593

Committed r208242: <http://trac.webkit.org/changeset/208242>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

media/modern-media-controls/placard-support/placard-support-airplay.html is timing out

See https://bugs.webkit.org/show_bug.cgi?id=164298