Bug 164298 – LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ryan Haddad]

LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html timing out

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-airplay.html

[Ryan Haddad]

Test was landed again with http://trac.webkit.org/changeset/208242, seems to be timing out on release builds.

[Ryan Haddad]

The test fails or times out on every run:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r210975%20(2974)/results.html

--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-actual.txt
@@ -1,13 +1,8 @@
+FAIL: Timed out waiting for notifyDone to be called
 Testing the PlacardSupport behavior when playing media through AirPlay.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-got event false
-got event true
-PASS mediaController.controls.showsPlacard is true
-PASS mediaController.controls.children.includes(mediaController.controls.airplayPlacard) is true
-PASS successfullyParsed is true
 
-TEST COMPLETE
-
+00:0600:00

[Ryan Haddad]

Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210979

[Antoine Quint]

Created attachment 299621 [details]
Patch

[Jon Lee]

Comment on attachment 299621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299621&action=review

> LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay.html:41
> +    window.internals.setMockMediaPlaybackTargetPickerState('Sleepy TV', 'DeviceAvailable');

If there are more of these. I think we should refactor all of this setup out to a helper script.

[WebKit Commit Bot]

Comment on attachment 299621 [details]
Patch

Clearing flags on attachment: 299621

Committed r211132: <http://trac.webkit.org/changeset/211132>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.