Bug 16349 - Double-clicking styles in the Computed Style or User Agent sections to edit them silently fails
Summary: Double-clicking styles in the Computed Style or User Agent sections to edit t...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 16350 21325 21488 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-12-07 16:37 PST by Adam Roben (:aroben)
Modified: 2011-07-01 06:18 PDT (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2007-12-07 16:37:15 PST
Double-clicking styles in the Computed Style section to edit them silently fails. I'm guessing that this is the source of a lot of the "inline css editing doesn't work" comments on <http://webkit.org/blog/148/web-inspector-update/>.

One possible solution is to make double-clicking a property in the Computed Style section copy that property to the Inline Style Attribute section and start editing it there. I think it's important that double-clicking in the Computed Style section let you edit *somewhere*, rather than popping up an error dialog or something.
Comment 1 Timothy Hatcher 2007-12-07 22:24:26 PST
The same happens for user agent rules and mapped attributes. We could allow editing those i think, but it seems weird.
Comment 2 Timothy Hatcher 2007-12-07 22:25:00 PST
*** Bug 16350 has been marked as a duplicate of this bug. ***
Comment 3 fALk Gärtner 2007-12-18 00:06:20 PST
For me editing also does not work on the inline element. no matter where you click I can only select values (for copying) but I can not change any of them. maybe there is something more fundamental missing on my part, but it sure as hell is no "click and play" at the moment ;) i double clicked everywhere tried every ctrl-click and there is just nowhere an edit value box as shown on the blog. 
Also I would love to click in the metrix box to change box models if that is possible. Just let me change whatever value I defined in the first place wherever it appears - in the code/stylesheet, in the stlye, metrics and property boxes - everywhere. would make life as a part time webdeveloper so much easier. 

Comment 4 Adam Roben (:aroben) 2008-01-02 06:42:10 PST
(In reply to comment #3)
> Also I would love to click in the metrix box to change box models if that is
> possible. Just let me change whatever value I defined in the first place
> wherever it appears - in the code/stylesheet, in the stlye, metrics and
> property boxes - everywhere. would make life as a part time webdeveloper so
> much easier. 

Could you file a new bug about this enhancement request?
Comment 5 Adam Roben (:aroben) 2008-01-29 11:07:32 PST
<rdar://problem/5712879>
Comment 6 Wout Mertens 2008-02-28 08:31:38 PST
the Firebug editor for Mozilla does allow adding ad-hoc css rules for an element.

Maybe double-clicking a computed style should create a new style box specific to the element and copy the attribute name and value into it, allowing the user to edit that.
Comment 7 Timothy Hatcher 2008-10-03 00:20:34 PDT
*** Bug 21325 has been marked as a duplicate of this bug. ***
Comment 8 Timothy Hatcher 2008-10-10 04:28:50 PDT
*** Bug 21488 has been marked as a duplicate of this bug. ***
Comment 9 Joseph Pecoraro 2009-10-20 21:48:27 PDT
Is this something that we want to add or should Computed / User Agent / Mapped Attribute styles be off limits to editing?  There are already plenty of other ways to add styles.

If we keep them uneditable then there should be some indication to the user (as evident by all the duplicates of this bug).
Comment 10 Timothy Hatcher 2009-10-21 03:27:41 PDT
(In reply to comment #9)
> Is this something that we want to add or should Computed / User Agent / Mapped
> Attribute styles be off limits to editing?  There are already plenty of other
> ways to add styles.
> 
> If we keep them uneditable then there should be some indication to the user (as
> evident by all the duplicates of this bug).

I think double click could copy the property to the Style Attribute section and edit.

We should also show non-editable sections differently. Maybe a "not pencel" icon in the section header like Finder uses for folders?
Comment 11 Alexander Pavlov (apavlov) 2010-11-10 03:21:42 PST
(In reply to comment #10)
> (In reply to comment #9)
> > Is this something that we want to add or should Computed / User Agent / Mapped
> > Attribute styles be off limits to editing?  There are already plenty of other
> > ways to add styles.
> > 
> > If we keep them uneditable then there should be some indication to the user (as
> > evident by all the duplicates of this bug).
> 
> I think double click could copy the property to the Style Attribute section and edit.
> 
> We should also show non-editable sections differently. Maybe a "not pencel" icon in the section header like Finder uses for folders?

Currently, we mark non-editable sections with a gray background which makes it quite clear that they are read-only. Does this sound good enough wrt the rw/ro distinction? Are we still bothered with letting the user edit at least something when they double-click inside the read-only section?
Comment 12 Alexander Pavlov (apavlov) 2011-07-01 06:18:53 PDT
The currently implemented graying-out seems to be a good and intuitively clear indicator of read-only sections.