Media controls need a way to let the user interact with the media's current time and see how it changes with labels. This task covers the creation of a TimeControl object that contains a Scrubber (see https://bugs.webkit.org/show_bug.cgi?id=163328) and two TimeLabel objects.
<rdar://problem/28741376>
Created attachment 291393 [details] Patch
It is expected that tests will fail until https://bugs.webkit.org/show_bug.cgi?id=163328 has landed.
Comment on attachment 291393 [details] Patch Attachment 291393 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2272787 New failing tests: media/modern-media-controls/time-label/time-label.html media/modern-media-controls/time-control/time-control.html
Created attachment 291402 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 291393 [details] Patch Attachment 291393 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2272794 New failing tests: media/modern-media-controls/time-label/time-label.html media/modern-media-controls/time-control/time-control.html
Created attachment 291403 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 291393 [details] Patch Attachment 291393 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2272814 New failing tests: media/modern-media-controls/time-label/time-label.html media/modern-media-controls/time-control/time-control.html
Created attachment 291405 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 291393 [details] Patch Attachment 291393 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2272771 New failing tests: media/modern-media-controls/time-label/time-label.html media/modern-media-controls/time-control/time-control.html
Created attachment 291407 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 291456 [details] Patch
Comment on attachment 291456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291456&action=review > Source/WebCore/Modules/modern-media-controls/controls/time-control.js:30 > +const MinimumScrubberWidth = 168; > +const ElapsedTimeLabelLeftMargin = -2; > +const ElapsedTimeLabelWidth = 45; > +const RemainingTimeLabelWidth = 49; > +const RemainingTimeLabelLeftMargin = 5; Where do all these come from? > Source/WebCore/Modules/modern-media-controls/controls/time-label.css:32 > + color: rgba(255, 255, 255, 0.572); Why 0.572? I think you should start taking these colors out to a variables.css file. > Source/WebCore/Modules/modern-media-controls/controls/time-label.js:77 > + return sign + timeStrings.map(x => String("00" + x).slice(-2)).join(":"); `00${x}`
(In reply to comment #13) > Comment on attachment 291456 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291456&action=review > > > Source/WebCore/Modules/modern-media-controls/controls/time-control.js:30 > > +const MinimumScrubberWidth = 168; > > +const ElapsedTimeLabelLeftMargin = -2; > > +const ElapsedTimeLabelWidth = 45; > > +const RemainingTimeLabelWidth = 49; > > +const RemainingTimeLabelLeftMargin = 5; > > Where do all these come from? The specs I've been provided. > > Source/WebCore/Modules/modern-media-controls/controls/time-label.css:32 > > + color: rgba(255, 255, 255, 0.572); > > Why 0.572? This is coming from the specs I've been provided. > I think you should start taking these colors out to a variables.css file. Yes, I'll do that as a followup task across all source files. > > Source/WebCore/Modules/modern-media-controls/controls/time-label.js:77 > > + return sign + timeStrings.map(x => String("00" + x).slice(-2)).join(":"); > > `00${x}` Nice. Will change as I land.
Created attachment 291498 [details] Patch for landing
Comment on attachment 291498 [details] Patch for landing Clearing flags on attachment: 291498 Committed r207295: <http://trac.webkit.org/changeset/207295>
All reviewed patches have been landed. Closing bug.