Bug 163387 - [Modern Media Controls] MediaControls base class
Summary: [Modern Media Controls] MediaControls base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 163356
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-13 06:59 PDT by Antoine Quint
Modified: 2016-10-13 12:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (24.54 KB, patch)
2016-10-13 07:04 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.34 MB, application/zip)
2016-10-13 07:46 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.84 MB, application/zip)
2016-10-13 08:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (1.07 MB, application/zip)
2016-10-13 08:13 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.97 MB, application/zip)
2016-10-13 08:30 PDT, Build Bot
no flags Details
Patch for landing (24.65 KB, patch)
2016-10-13 11:51 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-10-13 06:59:14 PDT
Now that we have the basic buttons and sliders to build media controls, we need objects to display them for various configurations. At first, we need a MediaControls base class that we will then subclass for specific configurations (macOS inline, macOS fullscreen, iOS inline).
Comment 1 Radar WebKit Bug Importer 2016-10-13 06:59:42 PDT
<rdar://problem/28753955>
Comment 2 Antoine Quint 2016-10-13 07:04:53 PDT
Created attachment 291479 [details]
Patch
Comment 3 Antoine Quint 2016-10-13 07:05:24 PDT
Tests will fail until https://bugs.webkit.org/show_bug.cgi?id=163356 lands.
Comment 4 Build Bot 2016-10-13 07:45:59 PDT
Comment on attachment 291479 [details]
Patch

Attachment 291479 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2277058

New failing tests:
media/modern-media-controls/media-controls/media-controls-start-button.html
media/modern-media-controls/media-controls/media-controls-constructor.html
media/modern-media-controls/media-controls/media-controls-placard.html
Comment 5 Build Bot 2016-10-13 07:46:00 PDT
Created attachment 291480 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-13 08:11:43 PDT
Comment on attachment 291479 [details]
Patch

Attachment 291479 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2277132

New failing tests:
media/modern-media-controls/media-controls/media-controls-start-button.html
media/modern-media-controls/media-controls/media-controls-constructor.html
media/modern-media-controls/media-controls/media-controls-placard.html
Comment 7 Build Bot 2016-10-13 08:11:46 PDT
Created attachment 291481 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-10-13 08:13:05 PDT
Comment on attachment 291479 [details]
Patch

Attachment 291479 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2277177

New failing tests:
media/modern-media-controls/media-controls/media-controls-start-button.html
media/modern-media-controls/media-controls/media-controls-constructor.html
media/modern-media-controls/media-controls/media-controls-placard.html
Comment 9 Build Bot 2016-10-13 08:13:07 PDT
Created attachment 291482 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-10-13 08:30:16 PDT
Comment on attachment 291479 [details]
Patch

Attachment 291479 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2277155

New failing tests:
media/modern-media-controls/media-controls/media-controls-start-button.html
media/modern-media-controls/media-controls/media-controls-constructor.html
media/modern-media-controls/media-controls/media-controls-placard.html
Comment 11 Build Bot 2016-10-13 08:30:19 PDT
Created attachment 291483 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Antoine Quint 2016-10-13 11:51:25 PDT
Created attachment 291502 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2016-10-13 12:05:07 PDT
Comment on attachment 291502 [details]
Patch for landing

Clearing flags on attachment: 291502

Committed r207299: <http://trac.webkit.org/changeset/207299>
Comment 14 WebKit Commit Bot 2016-10-13 12:05:11 PDT
All reviewed patches have been landed.  Closing bug.