Bug 162957 - WebRTC: Add support for the icecandidate event in MediaEndpointPeerConnection
Summary: WebRTC: Add support for the icecandidate event in MediaEndpointPeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211 162961
  Show dependency tree / graph
 
Reported: 2016-10-05 00:13 PDT by Adam Bergkvist
Modified: 2016-10-06 02:06 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (29.34 KB, patch)
2016-10-05 00:52 PDT, Adam Bergkvist 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (29.34 KB, patch)
2016-10-05 23:48 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Updated patch (for landing) (29.33 KB, patch)
2016-10-06 01:23 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-10-05 00:13:39 PDT 
The WebRTC backend dispatches locally gathered ICE candidates to the RTCPeerConnection object via the 'icecandidate' event.
Comment 1 Adam Bergkvist 2016-10-05 00:52:34 PDT 
Created attachment 290696 [details]
Proposed patch
Comment 2 Eric Carlson 2016-10-05 20:18:57 PDT 
Comment on attachment 290696 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290696&action=review

> Source/WebCore/ChangeLog:12
> +        Add API to Internals to emulate WebRTC platform events. Such as dispatching a set of ICE

Nit: "platform events. Such as" -> "platform events, such as"
Comment 3 Adam Bergkvist 2016-10-05 23:48:54 PDT 
Created attachment 290783 [details]
Patch for landing
Comment 4 Adam Bergkvist 2016-10-06 01:23:43 PDT 
Created attachment 290794 [details]
Updated patch (for landing)
Comment 5 Adam Bergkvist 2016-10-06 01:24:14 PDT 
Thanks for reviewing. Fixed nits in patch for landing.
Comment 6 WebKit Commit Bot 2016-10-06 01:57:19 PDT 
Comment on attachment 290794 [details]
Updated patch (for landing)

Clearing flags on attachment: 290794

Committed r206856: <http://trac.webkit.org/changeset/206856>