WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162957
WebRTC: Add support for the icecandidate event in MediaEndpointPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=162957
Summary
WebRTC: Add support for the icecandidate event in MediaEndpointPeerConnection
Adam Bergkvist
Reported
2016-10-05 00:13:39 PDT
The WebRTC backend dispatches locally gathered ICE candidates to the RTCPeerConnection object via the 'icecandidate' event.
Attachments
Proposed patch
(29.34 KB, patch)
2016-10-05 00:52 PDT
,
Adam Bergkvist
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(29.34 KB, patch)
2016-10-05 23:48 PDT
,
Adam Bergkvist
no flags
Details
Formatted Diff
Diff
Updated patch (for landing)
(29.33 KB, patch)
2016-10-06 01:23 PDT
,
Adam Bergkvist
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Bergkvist
Comment 1
2016-10-05 00:52:34 PDT
Created
attachment 290696
[details]
Proposed patch
Eric Carlson
Comment 2
2016-10-05 20:18:57 PDT
Comment on
attachment 290696
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=290696&action=review
> Source/WebCore/ChangeLog:12 > + Add API to Internals to emulate WebRTC platform events. Such as dispatching a set of ICE
Nit: "platform events. Such as" -> "platform events, such as"
Adam Bergkvist
Comment 3
2016-10-05 23:48:54 PDT
Created
attachment 290783
[details]
Patch for landing
Adam Bergkvist
Comment 4
2016-10-06 01:23:43 PDT
Created
attachment 290794
[details]
Updated patch (for landing)
Adam Bergkvist
Comment 5
2016-10-06 01:24:14 PDT
Thanks for reviewing. Fixed nits in patch for landing.
WebKit Commit Bot
Comment 6
2016-10-06 01:57:19 PDT
Comment on
attachment 290794
[details]
Updated patch (for landing) Clearing flags on attachment: 290794 Committed
r206856
: <
http://trac.webkit.org/changeset/206856
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug