Bug 162953 - [Win][Direct2D] Clean up Bitmap Decoder Implementation
Summary: [Win][Direct2D] Clean up Bitmap Decoder Implementation
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 162761 163349
Blocks: 161817
  Show dependency treegraph
Reported: 2016-10-04 18:55 PDT by Brent Fulgham
Modified: 2016-10-24 16:32 PDT (History)
6 users (show)

See Also:

Cleanups to make this code less gross. (1.72 KB, patch)
2016-10-14 17:24 PDT, Brent Fulgham
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-10-04 18:55:10 PDT
Address some of Said's comments from Bug 162761.
Comment 1 Brent Fulgham 2016-10-14 17:24:50 PDT
Created attachment 291685 [details]
Cleanups to make this code less gross.

This patch implements a set of improvements Said suggested in a prior review (made after the original patch landed).
Comment 2 WebKit Commit Bot 2016-10-14 17:35:23 PDT
Comment on attachment 291685 [details]
Cleanups to make this code less gross.

Rejecting attachment 291685 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 291685, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ex: platform/graphics/win/ImageDecoderDirect2D.cpp
|--- platform/graphics/win/ImageDecoderDirect2D.cpp	(revision 207357)
|+++ platform/graphics/win/ImageDecoderDirect2D.cpp	(working copy)
No file to patch.  Skipping patch.
2 out of 2 hunks ignored

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2287417
Comment 3 Darin Adler 2016-10-15 15:57:56 PDT
Comment on attachment 291685 [details]
Cleanups to make this code less gross.

View in context: https://bugs.webkit.org/attachment.cgi?id=291685&action=review

> platform/graphics/win/ImageDecoderDirect2D.cpp:175
> +    auto frameSize = frameSizeAtIndex(index, subsamplingLevel);
> +    return frameSize.area() * 4;

Would have made this a one-liner.
Comment 4 Brent Fulgham 2016-10-24 16:32:15 PDT
Landed in r207365. <https://trac.webkit.org/changeset/207365>