Bug 162953 – [Win][Direct2D] Clean up Bitmap Decoder Implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brent Fulgham]

Address some of Said's comments from Bug 162761.

[Brent Fulgham]

Created attachment 291685 [details]
Cleanups to make this code less gross.

This patch implements a set of improvements Said suggested in a prior review (made after the original patch landed).

[WebKit Commit Bot]

Comment on attachment 291685 [details]
Cleanups to make this code less gross.

Rejecting attachment 291685 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 291685, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ex: platform/graphics/win/ImageDecoderDirect2D.cpp
|===================================================================
|--- platform/graphics/win/ImageDecoderDirect2D.cpp	(revision 207357)
|+++ platform/graphics/win/ImageDecoderDirect2D.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2287417

[Darin Adler]

Comment on attachment 291685 [details]
Cleanups to make this code less gross.

View in context: https://bugs.webkit.org/attachment.cgi?id=291685&action=review

> platform/graphics/win/ImageDecoderDirect2D.cpp:175
> +    auto frameSize = frameSizeAtIndex(index, subsamplingLevel);
> +    return frameSize.area() * 4;

Would have made this a one-liner.

[Brent Fulgham]

Landed in r207365. <https://trac.webkit.org/changeset/207365>