Bug 162925 - [Win][Direct2D] Add Direct2D CMake rules
Summary: [Win][Direct2D] Add Direct2D CMake rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 161817
  Show dependency tree / graph
 
Reported: 2016-10-04 11:09 PDT by Brent Fulgham
Modified: 2016-10-06 13:37 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.59 KB, patch)
2016-10-05 20:40 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (17.73 KB, patch)
2016-10-06 10:15 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-10-04 11:09:24 PDT 
This patch updates the build rules on Windows to support an optional "Direct2D" build.
Comment 1 Brent Fulgham 2016-10-05 20:40:20 PDT 
Created attachment 290777 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 09:05:10 PDT 
Comment on attachment 290777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review

> Source/WebCore/ChangeLog:26
> +        * PlatformAppleWinCACG.cmake: Added.
> +        * PlatformWinDirect2D.cmake: Added.

I don't think we want more files in Source/WebCore just for this.  I think we should put things in PlatformWin and PlatformAppleWin with conditionals.

> Source/WebCore/page/win/FrameWinDirect2D.cpp:36
> +#include "NotImplemented.h"

This isn't used in this patch.
Comment 3 Alex Christensen 2016-10-06 09:14:23 PDT 
Comment on attachment 290777 [details]
Patch

r=me other than that.
Comment 4 Brent Fulgham 2016-10-06 09:58:35 PDT 
Comment on attachment 290777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290777&action=review

>> Source/WebCore/ChangeLog:26
>> +        * PlatformWinDirect2D.cmake: Added.
> 
> I don't think we want more files in Source/WebCore just for this.  I think we should put things in PlatformWin and PlatformAppleWin with conditionals.

OK. I'll do it that way.

>> Source/WebCore/page/win/FrameWinDirect2D.cpp:36
>> +#include "NotImplemented.h"
> 
> This isn't used in this patch.

Its needed in code that was already landed. When I merged from my local machine I missed this line, and since we don't build D2D on EWS (yet) I didn't notice the omission until I synced my local build.
Comment 5 Brent Fulgham 2016-10-06 10:15:03 PDT 
Created attachment 290827 [details]
Patch for landing
Comment 6 Brent Fulgham 2016-10-06 10:16:08 PDT 
Comment on attachment 290827 [details]
Patch for landing

Patch for landing.
Comment 7 WebKit Commit Bot 2016-10-06 11:04:03 PDT 
Comment on attachment 290827 [details]
Patch for landing

Clearing flags on attachment: 290827

Committed r206871: <http://trac.webkit.org/changeset/206871>
Comment 8 WebKit Commit Bot 2016-10-06 11:04:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Myles C. Maxfield 2016-10-06 13:37:24 PDT 
🎉