Bug 162784 - [SOUP] Simplify AuthenticationChallenge
Summary: [SOUP] Simplify AuthenticationChallenge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on: 162777
Blocks:
  Show dependency tree / graph
 
Reported: 2016-09-30 04:12 PDT by Carlos Garcia Campos
Modified: 2016-10-03 03:44 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.78 KB, patch)
2016-09-30 04:15 PDT, Carlos Garcia Campos 		achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.30 MB, application/zip)
2016-09-30 05:16 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-09-30 04:12:44 PDT 
We don't really need to keep references to the SoupSession and SoupMessage in AuthenticationChallenge, the SoupNetworkSession callback already forwards the challenge to the right ResourceHandle.
Comment 1 Carlos Garcia Campos 2016-09-30 04:15:02 PDT 
Created attachment 290325 [details]
Patch
Comment 2 Build Bot 2016-09-30 05:16:29 PDT 
Comment on attachment 290325 [details]
Patch

Attachment 290325 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2174711

New failing tests:
fast/images/pixel-crack-image-background-webkit-transform-scale.html
Comment 3 Build Bot 2016-09-30 05:16:32 PDT 
Created attachment 290328 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Alex Christensen 2016-09-30 07:28:27 PDT 
Comment on attachment 290325 [details]
Patch

r=me
gtk build failure will not exist once https://bugs.webkit.org/show_bug.cgi?id=162777 lands, right?
mac-wk2 test failure unrelated because none of this code is compiled on mac.
Comment 5 Carlos Garcia Campos 2016-09-30 07:30:57 PDT 
(In reply to comment #4)
> Comment on attachment 290325 [details]
> Patch
> 
> r=me
> gtk build failure will not exist once
> https://bugs.webkit.org/show_bug.cgi?id=162777 lands, right?
> mac-wk2 test failure unrelated because none of this code is compiled on mac.

Right!
Comment 6 Carlos Garcia Campos 2016-10-03 03:44:47 PDT 
Committed r206732: <http://trac.webkit.org/changeset/206732>