Bug 162777 - [SOUP] Cleanup persistent credential storage code
Summary: [SOUP] Cleanup persistent credential storage code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on:
Blocks: 162784
  Show dependency tree / graph
 
Reported: 2016-09-30 03:02 PDT by Carlos Garcia Campos
Modified: 2016-10-03 03:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (31.44 KB, patch)
2016-09-30 03:07 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (32.90 KB, patch)
2016-09-30 03:28 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Try to fix EFL build (32.90 KB, patch)
2016-09-30 03:39 PDT, Carlos Garcia Campos 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-09-30 03:02:22 PDT 
We have this feature behind ENABLE_CREDENTIAL_STORAGE flag, which is confusing, because we use credential storage unconditionally and this is only about persistent storage. Also the flag assumes libsecret is available, and since it's only used by GTK sometimes we use GTK ifdefs instead of CREDENTIAL_STORAGE. So, I think we should use USE(LIBSECRET) instead, and reduce a bit the ifdefs in common soup code. Another problem is that current implementation is always used, while it should depend on the current network storage session and never used in ephemeral sessions.
Comment 1 Carlos Garcia Campos 2016-09-30 03:07:27 PDT 
Created attachment 290313 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-30 03:10:18 PDT 
Attachment 290313 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:92:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-09-30 03:28:14 PDT 
Created attachment 290320 [details]
Try to fix EFL build
Comment 4 WebKit Commit Bot 2016-09-30 03:30:54 PDT 
Attachment 290320 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:92:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2016-09-30 03:39:42 PDT 
Created attachment 290322 [details]
Try to fix EFL build
Comment 6 WebKit Commit Bot 2016-09-30 03:41:37 PDT 
Attachment 290322 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:74:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/NetworkStorageSession.h:92:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Alex Christensen 2016-09-30 07:23:22 PDT 
Comment on attachment 290322 [details]
Try to fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=290322&action=review

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:201
> +    completionHandler(Credential());

{ }
Comment 8 Carlos Garcia Campos 2016-10-03 03:35:32 PDT 
Committed r206731: <http://trac.webkit.org/changeset/206731>