Bug 162235 - Adjust current networking logging
Summary: Adjust current networking logging
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Depends on: 162233
Blocks: 162237
  Show dependency treegraph
Reported: 2016-09-19 14:19 PDT by Keith Rollin
Modified: 2016-09-20 13:06 PDT (History)
5 users (show)

See Also:

Patch (22.61 KB, patch)
2016-09-19 17:02 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (21.92 KB, patch)
2016-09-19 17:45 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (21.93 KB, patch)
2016-09-20 11:57 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2016-09-19 14:19:04 PDT
Update the "always on" network logging in order to better track the loading of a particular resource and to better bind together the resources downloaded for a particular page and frame. Do this by consistently logging pageID, frameID, and resourceID.
Comment 1 Keith Rollin 2016-09-19 17:02:22 PDT
Created attachment 289287 [details]
Comment 2 Keith Rollin 2016-09-19 17:45:53 PDT
Created attachment 289294 [details]
Comment 3 Antti Koivisto 2016-09-19 17:46:06 PDT
Comment on attachment 289287 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=289287&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:141
> +    if (!m_hasReceivedData) {
> +        RELEASE_LOG_IF_ALLOWED("didReceiveData: Started receiving data (pageID = %llu, frameID = %llu, resourceID = %llu)", m_trackingParameters.pageID, m_trackingParameters.frameID, m_trackingParameters.resourceID);
> +        m_hasReceivedData = true;
> +    }

I think this patch includes also your previous patch.
Comment 4 Keith Rollin 2016-09-19 17:51:05 PDT
I think it's now fixed in patch 289294 in comment #2.
Comment 5 Antti Koivisto 2016-09-19 19:41:05 PDT
Comment on attachment 289294 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=289294&action=review

> Source/WebCore/loader/ResourceLoader.h:151
> +    Frame* frame() const { return m_frame.get(); }

Const accessors should generally return const objects:

const Frame* frame() const { ... }
Comment 6 Keith Rollin 2016-09-20 11:57:51 PDT
Created attachment 289390 [details]
Comment 7 WebKit Commit Bot 2016-09-20 12:40:42 PDT
Comment on attachment 289390 [details]

Rejecting attachment 289390 [details] from review queue.

krollin@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 8 WebKit Commit Bot 2016-09-20 13:05:59 PDT
Comment on attachment 289390 [details]

Clearing flags on attachment: 289390

Committed r206166: <http://trac.webkit.org/changeset/206166>
Comment 9 WebKit Commit Bot 2016-09-20 13:06:03 PDT
All reviewed patches have been landed.  Closing bug.