WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162233
Reduce logging from WebResourceLoader::didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=162233
Summary
Reduce logging from WebResourceLoader::didReceiveData
Keith Rollin
Reported
2016-09-19 14:16:56 PDT
Reduce the amount of logging performed by WebResourceLoader::didReceiveData when downloading resources -- only log once even if called multiple times for a single resource.
Attachments
Patch
(1.80 KB, patch)
2016-09-19 14:38 PDT
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
Patch
(2.33 KB, patch)
2016-09-19 14:52 PDT
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Keith Rollin
Comment 1
2016-09-19 14:38:05 PDT
Created
attachment 289259
[details]
Patch
Keith Rollin
Comment 2
2016-09-19 14:52:59 PDT
Created
attachment 289262
[details]
Patch
Antti Koivisto
Comment 3
2016-09-19 15:29:06 PDT
Comment on
attachment 289262
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=289262&action=review
> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138 > + RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size());
Should the message indicate that this was the first data received? It might be confusing if it appears that there was nothing more.
Keith Rollin
Comment 4
2016-09-19 15:33:20 PDT
(In reply to
comment #3
)
> Comment on
attachment 289262
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=289262&action=review
> > > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138 > > + RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size()); > > Should the message indicate that this was the first data received? It might > be confusing if it appears that there was nothing more.
This will be addressed in
Bug 162235
.
WebKit Commit Bot
Comment 5
2016-09-19 15:55:24 PDT
Comment on
attachment 289262
[details]
Patch Clearing flags on attachment: 289262 Committed
r206123
: <
http://trac.webkit.org/changeset/206123
>
WebKit Commit Bot
Comment 6
2016-09-19 15:55:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug