Bug 162233 - Reduce logging from WebResourceLoader::didReceiveData
Summary: Reduce logging from WebResourceLoader::didReceiveData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords:
Depends on:
Blocks: 162235
  Show dependency tree / graph
 
Reported: 2016-09-19 14:16 PDT by Keith Rollin
Modified: 2016-09-19 15:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2016-09-19 14:38 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2016-09-19 14:52 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2016-09-19 14:16:56 PDT 
Reduce the amount of logging performed by WebResourceLoader::didReceiveData when downloading resources -- only log once even if called multiple times for a single resource.
Comment 1 Keith Rollin 2016-09-19 14:38:05 PDT 
Created attachment 289259 [details]
Patch
Comment 2 Keith Rollin 2016-09-19 14:52:59 PDT 
Created attachment 289262 [details]
Patch
Comment 3 Antti Koivisto 2016-09-19 15:29:06 PDT 
Comment on attachment 289262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289262&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138
> +        RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size());

Should the message indicate that this was the first data received? It might be confusing if it appears that there was nothing more.
Comment 4 Keith Rollin 2016-09-19 15:33:20 PDT 
(In reply to comment #3)
> Comment on attachment 289262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289262&action=review
> 
> > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138
> > +        RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size());
> 
> Should the message indicate that this was the first data received? It might
> be confusing if it appears that there was nothing more.

This will be addressed in Bug 162235.
Comment 5 WebKit Commit Bot 2016-09-19 15:55:24 PDT 
Comment on attachment 289262 [details]
Patch

Clearing flags on attachment: 289262

Committed r206123: <http://trac.webkit.org/changeset/206123>
Comment 6 WebKit Commit Bot 2016-09-19 15:55:29 PDT 
All reviewed patches have been landed.  Closing bug.