RESOLVED FIXED Bug 162090
[Win][Direct2D] Provide Color support for Direct2D 
https://bugs.webkit.org/show_bug.cgi?id=162090
Summary [Win][Direct2D] Provide Color support for Direct2D
Brent Fulgham
Reported 2016-09-16 14:26:42 PDT
Add some casting operators to Color to allow conversion to/from native Direct2D types.
Attachments
Patch (4.69 KB, patch)
2016-09-16 14:32 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-09-16 14:32:54 PDT
Created attachment 289113 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-16 14:34:38 PDT
Attachment 289113 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/Color.h:45: D2D_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/Color.h:46: D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/win/ColorDirect2D.cpp:41: D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3 2016-09-16 17:16:24 PDT
Committed r206056: <http://trac.webkit.org/changeset/206056>
Note You need to log in before you can comment on or make changes to this bug.