Bug 162090 - [Win][Direct2D] Provide Color support for Direct2D
Summary: [Win][Direct2D] Provide Color support for Direct2D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All Windows 10
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 161817
  Show dependency tree / graph
 
Reported: 2016-09-16 14:26 PDT by Brent Fulgham
Modified: 2016-09-16 17:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2016-09-16 14:32 PDT, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-09-16 14:26:42 PDT 
Add some casting operators to Color to allow conversion to/from native Direct2D types.
Comment 1 Brent Fulgham 2016-09-16 14:32:54 PDT 
Created attachment 289113 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-16 14:34:38 PDT 
Attachment 289113 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Color.h:45:  D2D_COLOR_F is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:46:  D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/win/ColorDirect2D.cpp:41:  D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2016-09-16 17:16:24 PDT 
Committed r206056: <http://trac.webkit.org/changeset/206056>