Bug 162068 - Use correct encodings in URL::setQuery
Summary: Use correct encodings in URL::setQuery
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-16 10:47 PDT by Alex Christensen
Modified: 2023-09-09 08:41 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-16 10:47:56 PDT 
https://bugs.webkit.org/show_bug.cgi?id=161176 assumes everything is UTF8.  This is progress, but not correct.  Sometimes the Document's TextEncoding should be used.  This should make even more web platform tests pass.
Comment 1 Anne van Kesteren 2018-05-09 03:23:56 PDT 
See https://github.com/w3c/web-platform-tests/pull/10915 for additional test coverage here and https://github.com/whatwg/url/pull/386 for a change to the URL Standard that tweaks the details here to make things better for web developers.
Comment 2 Anne van Kesteren 2023-09-09 08:41:16 PDT 
As of some time ago, assuming everything is UTF-8 is correct for the query/search setter.

I fixed the remaining tests in https://github.com/web-platform-tests/wpt/commit/8236142e9de79b5f9b4d97b086d4b1bf5c6a3ce4.