Bug 161176 – URL::setQuery should handle non-ASCII characters

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Alex Christensen]

imported/w3c/web-platform-tests/url/url-setters.html asserts.  It shouldn't.

[Ryan Haddad]

*** Bug 161201 has been marked as a duplicate of this bug. ***

[Alex Christensen]

Created attachment 289071 [details]
Patch

[WebKit Commit Bot]

Attachment 289071 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 289071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289071&action=review

> Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:115
> +        result.setQuery("t=" + timeID, UTF8Encoding());

It is true that not all of these should be UTF8Encoding, but this is a step in the right direction, and there are web platform tests for the cases in which it should be the Document's encoding that are currently failing but won't be once I fix them.

[Alex Christensen]

Created attachment 289076 [details]
Patch

[Build Bot]

Comment on attachment 289076 [details]
Patch

Attachment 289076 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2089243

New failing tests:
fast/forms/state-restore-broken-state.html

[Build Bot]

Created attachment 289085 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289076 [details]
Patch

Attachment 289076 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2089266

New failing tests:
fast/forms/state-restore-broken-state.html
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 289086 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289076 [details]
Patch

Attachment 289076 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2089248

New failing tests:
fast/forms/state-restore-broken-state.html

[Build Bot]

Created attachment 289088 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289076 [details]
Patch

Attachment 289076 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2089268

New failing tests:
fast/forms/state-restore-broken-state.html
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 289091 [details]
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 289097 [details]
Patch

[Build Bot]

Comment on attachment 289097 [details]
Patch

Attachment 289097 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2089928

New failing tests:
fast/forms/submit-nil-value-field-assert.html
http/tests/navigation/onload-navigation-iframe.html
http/tests/history/redirect-js-form-submit-2-seconds.html
http/tests/navigation/onload-navigation-iframe-timeout.html
fast/forms/empty-get.html
http/tests/navigation/back-send-referrer.html
http/tests/download/inherited-encoding-form-submission-result.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html
fast/dom/DOMURL/set-href-attribute-search.html
fast/forms/missing-action.html
fast/history/gesture-before-onload-form-submit.html
http/tests/navigation/onload-navigation-iframe-2.html
fast/loader/form-submission-before-load-get.html
http/tests/history/redirect-js-form-submit-before-load.html
http/tests/history/redirect-js-form-submit-0-seconds.html
fast/forms/get-forms-to-about-blank.html

[Build Bot]

Created attachment 289108 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289097 [details]
Patch

Attachment 289097 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2089959

New failing tests:
fast/forms/get-forms-to-about-blank.html
fast/forms/submit-nil-value-field-assert.html
http/tests/navigation/onload-navigation-iframe.html
http/tests/navigation/onload-navigation-iframe-timeout.html
fast/forms/empty-get.html
http/tests/navigation/back-send-referrer.html
http/tests/history/redirect-js-form-submit-2-seconds.html
http/tests/download/inherited-encoding-form-submission-result.html
fast/dom/DOMURL/set-href-attribute-search.html
fast/loader/form-submission-before-load-get.html
fast/history/gesture-before-onload-form-submit.html
http/tests/navigation/onload-navigation-iframe-2.html
fast/forms/missing-action.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html
http/tests/history/redirect-js-form-submit-0-seconds.html
http/tests/history/redirect-js-form-submit-before-load.html

[Build Bot]

Created attachment 289109 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289097 [details]
Patch

Attachment 289097 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2089963

New failing tests:
fast/forms/submit-nil-value-field-assert.html
http/tests/history/redirect-js-form-submit-before-load.html
http/tests/navigation/onload-navigation-iframe.html
http/tests/navigation/onload-navigation-iframe-timeout.html
fast/forms/empty-get.html
http/tests/navigation/back-send-referrer.html
http/tests/history/redirect-js-form-submit-2-seconds.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html
fast/dom/DOMURL/set-href-attribute-search.html
fast/forms/missing-action.html
fast/history/gesture-before-onload-form-submit.html
http/tests/navigation/onload-navigation-iframe-2.html
fast/loader/form-submission-before-load-get.html
imported/w3c/web-platform-tests/url/url-setters.html
http/tests/history/redirect-js-form-submit-0-seconds.html
fast/forms/get-forms-to-about-blank.html

[Build Bot]

Created attachment 289111 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289097 [details]
Patch

Attachment 289097 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2090004

New failing tests:
fast/forms/submit-nil-value-field-assert.html
http/tests/history/redirect-js-form-submit-before-load.html
http/tests/navigation/onload-navigation-iframe.html
http/tests/navigation/onload-navigation-iframe-timeout.html
fast/forms/empty-get.html
http/tests/navigation/back-send-referrer.html
http/tests/history/redirect-js-form-submit-2-seconds.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html
fast/dom/DOMURL/set-href-attribute-search.html
http/tests/history/redirect-js-form-submit-0-seconds.html
http/tests/navigation/onload-navigation-iframe-2.html
fast/forms/missing-action.html
imported/w3c/web-platform-tests/url/url-setters.html
fast/forms/get-forms-to-about-blank.html

[Build Bot]

Created attachment 289114 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Anne van Kesteren]

This is INVALID just like bug 185419 as the standard doesn't pass in an encoding argument for any of the setters.

I filed https://github.com/whatwg/url/issues/783 to clarify this and created https://github.com/web-platform-tests/wpt/pull/41785 to fix the remaining tests.