I think the code may have the same issue on Windows as it did on GCC at -Os in this bug: https://bugs.webkit.org/show_bug.cgi?id=155371 Now that the functions are always inlined the Windows issue may be no more. Let's throw a patch at the bots and see if they're happy!
Created attachment 288961 [details] patch Throwing it to the bots, let's see if they're happy.
Created attachment 288962 [details] patch Wrong patch....
Comment on attachment 288962 [details] patch Well, you should probably make sure the windows bot builds first.
(In reply to comment #3) > Comment on attachment 288962 [details] > patch > > Well, you should probably make sure the windows bot builds first. Yeah I was hoping it would fail because of my patch, or be green... it's failing without my patch :(
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 288962 [details] > > patch > > > > Well, you should probably make sure the windows bot builds first. > > Yeah I was hoping it would fail because of my patch, or be green... it's > failing without my patch :( Trying to fix it here: https://bugs.webkit.org/show_bug.cgi?id=162031
Created attachment 289996 [details] patch Windows build was fixed a while ago, rebasing and re-uploading since I wrote my patch a few days ago. Sam Weinig had r+'d the previous match.
Comment on attachment 289996 [details] patch Windows bot was temporarily borked again. Should be fixed now...
Created attachment 290005 [details] patch Same patch, Windows bot is now fixed.
Comment on attachment 290005 [details] patch r=me
Comment on attachment 290005 [details] patch Clearing flags on attachment: 290005 Committed r206468: <http://trac.webkit.org/changeset/206468>
All reviewed patches have been landed. Closing bug.