Bug 162031 - Fix missing JSMediaStreamTrackSourcesCallback.cpp
Summary: Fix missing JSMediaStreamTrackSourcesCallback.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 10
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-15 13:30 PDT by JF Bastien
Modified: 2016-09-27 12:16 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.34 KB, patch)
2016-09-15 13:32 PDT, JF Bastien
ysuzuki: review+
Details | Formatted Diff | Diff
patch (1.62 KB, patch)
2016-09-15 15:15 PDT, JF Bastien
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-09-15 13:30:44 PDT
The Windows build is failing on bots:
C:\cygwin\home\buildbot\WebKit\Source\WebCore\DerivedSources.cpp(345): fatal error C1083: Cannot open include file: 'JSMediaStreamTrackSourcesCallback.cpp': No such file or directory [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]

This file doesn't seem to exist anymore.
Comment 1 JF Bastien 2016-09-15 13:32:13 PDT
Created attachment 288989 [details]
patch
Comment 2 Yusuke Suzuki 2016-09-15 13:37:17 PDT
Comment on attachment 288989 [details]
patch

r=me
Comment 3 JF Bastien 2016-09-15 13:42:18 PDT
I'll wait to see if the Win bot succeeds before committing manually.
Comment 4 JF Bastien 2016-09-15 15:15:04 PDT
Created attachment 289006 [details]
patch

JSSourceInfo.cpp is also gone.
Comment 5 JF Bastien 2016-09-16 11:35:31 PDT
Comment on attachment 289006 [details]
patch

Windows is green with this.
Comment 6 WebKit Commit Bot 2016-09-16 11:36:31 PDT
Comment on attachment 289006 [details]
patch

Rejecting attachment 289006 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 289006, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/DerivedSources.cpp
Hunk #1 FAILED at 342.
Hunk #2 succeeded at 420 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/DerivedSources.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2089335
Comment 7 JF Bastien 2016-09-27 12:16:17 PDT
This was fixed in r206034 and r206024. Closing.