Bug 161595 - run-bindings-tests fails since r205422
Summary: run-bindings-tests fails since r205422
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 23:39 PDT by Fujii Hironori
Modified: 2016-09-05 10:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch (47.61 KB, patch)
2016-09-04 23:46 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2016-09-04 23:39:55 PDT 
> FAIL: (JS) JSTestClassWithJSBuiltinConstructor.h
> --- WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h	2016-06-27 13:08:07.537464007 -0700
> +++ /tmp/tmpIsGJea/JSTestClassWithJSBuiltinConstructor.h	2016-09-04 23:35:01.119239257 -0700
> @@ -84,5 +84,8 @@
>  JSC::JSValue toJSNewlyCreated(JSC::ExecState*, JSDOMGlobalObject*, Ref<TestClassWithJSBuiltinConstructor>&&);
>  inline JSC::JSValue toJSNewlyCreated(JSC::ExecState* state, JSDOMGlobalObject* globalObject, RefPtr<TestClassWithJSBuiltinConstructor>&& impl) { return impl ? toJSNewlyCreated(state, globalObject, impl.releaseNonNull()) : JSC::jsNull(); }
>  
> +template<> struct JSDOMWrapperConverterTraits<TestClassWithJSBuiltinConstructor> {
> +    using WrapperClass = JSTestClassWithJSBuiltinConstructor;
> +};
>  
>  } // namespace WebCore
> 
> FAIL: (JS) JSTestClassWithJSBuiltinConstructor.cpp
> --- WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp	2016-09-01 05:31:58.238514962 -0700
> +++ /tmp/tmpIsGJea/JSTestClassWithJSBuiltinConstructor.cpp	2016-09-04 23:35:01.119239257 -0700
> @@ -201,7 +201,7 @@
>      // by adding the SkipVTableValidation attribute to the interface IDL definition
>      RELEASE_ASSERT(actualVTablePointer == expectedVTablePointer);
>  #endif
> -    return createWrapper<JSTestClassWithJSBuiltinConstructor, TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl));
> +    return createWrapper<TestClassWithJSBuiltinConstructor>(globalObject, WTFMove(impl));
>  }
>  
>  JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, TestClassWithJSBuiltinConstructor& impl)
Comment 1 Fujii Hironori 2016-09-04 23:46:40 PDT 
Created attachment 287933 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-05 10:27:49 PDT 
Comment on attachment 287933 [details]
Patch

Clearing flags on attachment: 287933

Committed r205458: <http://trac.webkit.org/changeset/205458>
Comment 3 WebKit Commit Bot 2016-09-05 10:27:53 PDT 
All reviewed patches have been landed.  Closing bug.