Bug 161580 - Remove the CREATE_DOM_WRAPPER macro
Summary: Remove the CREATE_DOM_WRAPPER macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 18:11 PDT by Sam Weinig
Modified: 2017-05-21 11:15 PDT (History)
14 users (show)

See Also:

Attachments
Patch (43.62 KB, patch)
2016-09-04 18:20 PDT, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-09-04 18:11:20 PDT 
Remove the CREATE_DOM_WRAPPER macro
Comment 1 Sam Weinig 2016-09-04 18:20:35 PDT 
Created attachment 287924 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-04 18:22:34 PDT 
Attachment 287924 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:484:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2016-09-04 18:22:45 PDT 
I thought about doing this in the other direction, making it createWrapper<WrapperType>(...), but couldn't convince myself one way was better than another, so I went this way. I have plans to use the mapping established by JSDOMWrapperConverterTraits for more things going forward, so this seems ok.
Comment 4 Sam Weinig 2016-09-04 20:13:51 PDT 
Committed r205422: <http://trac.webkit.org/changeset/205422>
Comment 5 Csaba Osztrogonác 2016-09-05 00:08:25 PDT 
(In reply to comment #4)
> Committed r205422: <http://trac.webkit.org/changeset/205422>

It broke the bindings generation tests, pleasw fix them.