Currently, it is hard to find out which bot processed a patch. Current method is to ssh in all the bots and look into the logs. EWS should clearly indicate which patch is being processed by which bot.
Created attachment 287062 [details] Proposed patch
Comment on attachment 287062 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review > Tools/QueueStatusServer/handlers/statusbubble.py:134 > + bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n" Unit test?
Comment on attachment 287062 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review >> Tools/QueueStatusServer/handlers/statusbubble.py:134 >> + bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n" > > Unit test? R => r ?
Created attachment 287082 [details] updated patch Changed R => r in " Recent messages". Also added "Started processing patch" message to progress_statuses, without this EWS will consider this as failure status and make the status bubbles orange. This particular code is in Tools/QueueStatusServer, we haven't maintained unit-tests for QueueStatusServer.
The commit-queue encountered the following flaky tests while processing attachment 287082 [details]: The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 287082 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 287082 [details] updated patch Clearing flags on attachment: 287082 Committed r205010: <http://trac.webkit.org/changeset/205010>
All reviewed patches have been landed. Closing bug.
This seems somewhat confusing to me. A patch can move from one bot to another. If a test cycle finishes without a result, the lock is simply dropped, and any bot is free to pick up the patch for a retry. Which of the bots is given here, the first one or the current one? In either case, we need to make it explicit in the status.
In this patch, bot is shown only when patch is in processing, and it shows the first bot. Will write another patch to cover all the cases.
https://bugs.webkit.org/show_bug.cgi?id=161280 covers all the cases. It shows bot number corresponding to each status message. e.g.: https://webkit-queues.webkit.org/patch/287182
As far as I can tell, the bubble remains incorrect/confusing.
yeah, should we revert the bubble change done in this bug, or try to display bot_id in each status message in the bubble?
Created attachment 287322 [details] Semi-reverting this patch Removing bot id from status bubble. We still need other changes made in the previous patch.
Re-opening for CQ to work on the new patch.
Comment on attachment 287322 [details] Semi-reverting this patch Clearing flags on attachment: 287322 Committed r205149: <http://trac.webkit.org/changeset/205149>