Bug 161220 - webkit-queues queue-status page should should list more recent statuses
Summary: webkit-queues queue-status page should should list more recent statuses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-25 17:41 PDT by Aakash Jain
Modified: 2016-08-26 15:54 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (1.28 KB, patch)
2016-08-25 18:50 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2 (710.43 KB, application/zip)
2016-08-25 22:44 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-08-25 17:41:06 PDT
For e.g.: https://webkit-queues.webkit.org/queue-status/ios-ews currently lists 15 recent status. It should list more recent status in order to easily debug issues.
Comment 1 Aakash Jain 2016-08-25 18:50:05 PDT
Created attachment 287058 [details]
Proposed patch
Comment 2 Daniel Bates 2016-08-25 20:25:12 PDT
Comment on attachment 287058 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287058&action=review

> Tools/QueueStatusServer/handlers/queuestatus.py:65
> +        return statuses.order("-date").fetch(50)

Can we add a unit test?
Comment 3 Build Bot 2016-08-25 22:44:23 PDT
Comment on attachment 287058 [details]
Proposed patch

Attachment 287058 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1944208

New failing tests:
fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html
Comment 4 Build Bot 2016-08-25 22:44:26 PDT
Created attachment 287075 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 5 Aakash Jain 2016-08-26 15:50:15 PDT
Comment on attachment 287058 [details]
Proposed patch

We haven't maintained unit-tests for QueueStatusServer.
Comment 6 WebKit Commit Bot 2016-08-26 15:53:56 PDT
Comment on attachment 287058 [details]
Proposed patch

Clearing flags on attachment: 287058

Committed r205054: <http://trac.webkit.org/changeset/205054>
Comment 7 WebKit Commit Bot 2016-08-26 15:54:00 PDT
All reviewed patches have been landed.  Closing bug.