LayoutTest webgl/max-active-contexts-webglcontextlost-prevent-default.html is a flaky timeout https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2Fmax-active-contexts-webglcontextlost-prevent-default.html
This test has been flaky since 8/23/2016 11:03:06 AM ~r204840
Possibly related? http://trac.webkit.org/changeset/204839
Marked test as flaky on mac-wk1 in http://trac.webkit.org/projects/webkit/changeset/205059
Hmm, no new failures today, so may also be related to bug 161249.
I am able to reproduce the flaky time out locally like so: Tools/Scripts/run-webkit-tests --release -1 --repeat-each=500 webgl/max-active-contexts-webglcontextlost-prevent-default.html I will investigate to see if this is caused by my change at r204839.
Fix on the way.
Created attachment 287647 [details] Patch
I am actually still confirming this is caused by r204839. I have just realized I am forgotten to update TestExpectations locally, which is why the test started passing.
I have confirmed this is caused by r204839 and I have an idea of what could be happening. I am working on a fix. If it takes to long to figure out, I'll rollout r204839.
Created attachment 287659 [details] Patch
Created attachment 287661 [details] Patch
Created attachment 287664 [details] Patch
Comment on attachment 287664 [details] Patch Attachment 287664 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1989154 New failing tests: webgl/1.0.2/conformance/extensions/oes-texture-float.html
Created attachment 287678 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 287689 [details] Patch
Created attachment 287694 [details] Patch
Comment on attachment 287694 [details] Patch All green. Geoff, is this something you could review? I don't know who else is familiar with isReachableFromOpaqueRoots / visitAdditionalChildren.
Created attachment 287701 [details] Patch
Comment on attachment 287701 [details] Patch r=me
Comment on attachment 287701 [details] Patch Clearing flags on attachment: 287701 Committed r205360: <http://trac.webkit.org/changeset/205360>
All reviewed patches have been landed. Closing bug.