Bug 161054 - CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface
Summary: CanvasRenderingContext2D should not have a CanvasRenderingContext parent inte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on: 161205
Blocks:
  Show dependency tree / graph
 
Reported: 2016-08-22 13:26 PDT by Chris Dumez
Modified: 2016-09-01 11:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (34.17 KB, patch)
2016-08-22 14:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.20 KB, patch)
2016-08-22 19:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.20 KB, patch)
2016-08-22 19:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-22 13:26:29 PDT 
CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface as per:
- https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d

Firefox and Chrome agree with the specification.
Comment 1 Chris Dumez 2016-08-22 14:56:22 PDT 
Created attachment 286623 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-22 16:25:09 PDT 
Comment on attachment 286623 [details]
Patch

Clearing flags on attachment: 286623

Committed r204745: <http://trac.webkit.org/changeset/204745>
Comment 3 WebKit Commit Bot 2016-08-22 16:25:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2016-08-22 17:05:00 PDT 
Reverted r204745 for reason:

Broke the Windows build

Committed r204748: <http://trac.webkit.org/changeset/204748>
Comment 5 Chris Dumez 2016-08-22 19:18:18 PDT 
Created attachment 286650 [details]
Patch
Comment 6 Chris Dumez 2016-08-22 19:19:30 PDT 
Created attachment 286651 [details]
Patch
Comment 7 Chris Dumez 2016-08-23 08:35:52 PDT 
Comment on attachment 286651 [details]
Patch

Clearing flags on attachment: 286651

Committed r204839: <http://trac.webkit.org/changeset/204839>
Comment 8 Chris Dumez 2016-08-23 08:35:58 PDT 
All reviewed patches have been landed.  Closing bug.