161100 – Typed arrays should use MarkedSpace instead of CopiedSpace

RESOLVED FIXED Bug 161100

Typed arrays should use MarkedSpace instead of CopiedSpace

https://bugs.webkit.org/show_bug.cgi?id=161100

Summary Typed arrays should use MarkedSpace instead of CopiedSpace

Filip Pizlo

Reported 2016-08-23 13:19:53 PDT

Patch forthcoming.

Attachments
the patch (15.44 KB, patch) 2016-08-23 15:22 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
patch for landing (15.54 KB, patch) 2016-08-23 15:34 PDT, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-yosemite (2.42 MB, application/zip) 2016-08-23 19:53 PDT, Build Bot	no flags	Details
patch for landing (33.24 KB, patch) 2016-09-06 09:52 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
patch for relanding (33.24 KB, patch) 2016-09-07 17:02 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-08-23 13:43:12 PDT

*** Bug 125425 has been marked as a duplicate of this bug. ***

Filip Pizlo

Comment 2 2016-08-23 15:22:33 PDT

Created attachment 286788 [details] the patch

Geoffrey Garen

Comment 3 2016-08-23 15:26:02 PDT

Comment on attachment 286788 [details] the patch r=me

Filip Pizlo

Comment 4 2016-08-23 15:34:44 PDT

Created attachment 286792 [details] patch for landing I fixed some goofs.

Build Bot

Comment 5 2016-08-23 19:53:29 PDT

Comment on attachment 286792 [details] patch for landing Attachment 286792 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1931454 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html webgl/1.0.3/conformance/extensions/oes-texture-float-linear.html imported/w3c/WebCryptoAPI/digest/test_digest.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html fast/canvas/webgl/drawingbuffer-test.html webgl/1.0.2/conformance/textures/texture-size-cube-maps.html fast/canvas/webgl/uninitialized-test.html webgl/1.0.2/conformance/misc/uninitialized-test.html webgl/1.0.2/conformance/textures/texture-size.html webgl/1.0.2/conformance/canvas/drawingbuffer-hd-dpi-test.html

Build Bot

Comment 6 2016-08-23 19:53:33 PDT

Created attachment 286825 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Filip Pizlo

Comment 7 2016-09-06 09:52:46 PDT

Created attachment 288031 [details] patch for landing

WebKit Commit Bot

Comment 8 2016-09-06 09:54:58 PDT

Attachment 288031 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:47: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:48: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:49: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:50: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 6 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 9 2016-09-06 11:22:03 PDT

Landed in https://trac.webkit.org/changeset/205494

Ryan Haddad

Comment 10 2016-09-06 13:49:04 PDT

This change appears to have broken the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/80295

WebKit Commit Bot

Comment 11 2016-09-06 14:42:41 PDT

Re-opened since this is blocked by bug 161646

Filip Pizlo

Comment 12 2016-09-07 17:02:09 PDT

Created attachment 288207 [details] patch for relanding

WebKit Commit Bot

Comment 13 2016-09-07 17:04:33 PDT

Attachment 288207 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:46: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:47: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:48: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:49: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:50: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 6 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 14 2016-09-08 12:03:32 PDT

Relanded in https://trac.webkit.org/changeset/205648

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component JavaScriptCore

Assignee

Filip Pizlo

Reported

2016-08-23 13:19 PDT

Modified

2016-09-08 12:03 PDT History

CC List

6 users Show

URL

Keywords

Depends on

161646

Blocks

159658

Dependancies

tree graph