WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161053
Rename MathMLInlineContainerElement to MathMLPresentationElement
https://bugs.webkit.org/show_bug.cgi?id=161053
Summary
Rename MathMLInlineContainerElement to MathMLPresentationElement
Frédéric Wang (:fredw)
Reported
2016-08-22 12:40:40 PDT
Another step for
bug 160543
. MathMLInlineContainerElement sounds a bad name for something that is now going to produce RenderMathMLBlocks. At the moment most of the presentation MathML elements are actually MathMLInlineContainerElement and I believe most of the code of MathMLElement could be moved in that derived class. A MathMLUnknownElement class could be introduced for unknown elements, following what is done in SVG or HTML classes.
Attachments
Patch
(33.34 KB, patch)
2016-08-22 12:56 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch
(25.88 KB, patch)
2016-08-23 01:43 PDT
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch
(25.87 KB, patch)
2016-08-23 03:09 PDT
,
Frédéric Wang (:fredw)
rego
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2016-08-22 12:56:41 PDT
Created
attachment 286614
[details]
Patch
Frédéric Wang (:fredw)
Comment 2
2016-08-23 01:43:09 PDT
Created
attachment 286691
[details]
Patch
Frédéric Wang (:fredw)
Comment 3
2016-08-23 03:09:07 PDT
Created
attachment 286695
[details]
Patch
Manuel Rego Casasnovas
Comment 4
2016-08-23 03:57:16 PDT
Comment on
attachment 286695
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=286695&action=review
r=me
> Source/WebCore/ChangeLog:7 > +
It'd be nice to add the explanation of the rename here and not only in the bug comments.
Frédéric Wang (:fredw)
Comment 5
2016-08-23 04:38:17 PDT
Committed
r204809
: <
http://trac.webkit.org/changeset/204809
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug