Bug 161053 - Rename MathMLInlineContainerElement to MathMLPresentationElement
Summary: Rename MathMLInlineContainerElement to MathMLPresentationElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 161050
Blocks: 160543
  Show dependency treegraph
 
Reported: 2016-08-22 12:40 PDT by Frédéric Wang (:fredw)
Modified: 2016-08-23 04:38 PDT (History)
4 users (show)

See Also:


Attachments
Patch (33.34 KB, patch)
2016-08-22 12:56 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (25.88 KB, patch)
2016-08-23 01:43 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (25.87 KB, patch)
2016-08-23 03:09 PDT, Frédéric Wang (:fredw)
rego: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-08-22 12:40:40 PDT
Another step for bug 160543.

MathMLInlineContainerElement sounds a bad name for something that is now going to produce RenderMathMLBlocks. At the moment most of the presentation MathML elements are actually MathMLInlineContainerElement and I believe most of the code of MathMLElement could be moved in that derived class. A MathMLUnknownElement class could be introduced for unknown elements, following what is done in SVG or HTML classes.
Comment 1 Frédéric Wang (:fredw) 2016-08-22 12:56:41 PDT
Created attachment 286614 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-08-23 01:43:09 PDT
Created attachment 286691 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2016-08-23 03:09:07 PDT
Created attachment 286695 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2016-08-23 03:57:16 PDT
Comment on attachment 286695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286695&action=review

r=me

> Source/WebCore/ChangeLog:7
> +

It'd be nice to add the explanation of the rename here and not only in the bug comments.
Comment 5 Frédéric Wang (:fredw) 2016-08-23 04:38:17 PDT
Committed r204809: <http://trac.webkit.org/changeset/204809>