Bug 161050 - Introduce a MathMLRowElement class for mrow-like elements
Summary: Introduce a MathMLRowElement class for mrow-like elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 160543 161053 161230 161232
  Show dependency tree / graph
 
Reported: 2016-08-22 12:07 PDT by Frédéric Wang (:fredw)
Modified: 2016-08-26 02:18 PDT (History)
0 users

See Also:

Attachments
Patch (21.98 KB, patch)
2016-08-22 12:29 PDT, Frédéric Wang (:fredw) 		darin: review+
Details | Formatted Diff | Diff
Patch (38.84 KB, patch)
2016-08-23 00:55 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-08-22 12:07:50 PDT 
Another step for bug 160543.
Comment 1 Frédéric Wang (:fredw) 2016-08-22 12:29:35 PDT 
Created attachment 286612 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2016-08-22 12:57:57 PDT 
Comment on attachment 286612 [details]
Patch

I noticed that the constructor of RenderMathMLRow (and its derived class) can now take MathMLRowElement (or a derived class) as a parameter.
Comment 3 Darin Adler 2016-08-22 23:45:25 PDT 
Comment on attachment 286612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286612&action=review

> Source/WebCore/mathml/MathMLRowElement.h:39
> +    void childrenChanged(const ChildChange&) final;

Seems this could be private instead of protected.

> Source/WebCore/mathml/MathMLRowElement.h:42
> +    bool acceptsDisplayStyleAttribute() override;
> +    bool acceptsMathVariantAttribute() override;

Seems these could both be final instead of override and private instead of protected.
Comment 4 Frédéric Wang (:fredw) 2016-08-23 00:55:01 PDT 
Created attachment 286689 [details]
Patch

Updated patch that also force renderer constructors to take a MathMLRowElement and make more element classes inherits from MathMLRowElement.
Comment 5 Frédéric Wang (:fredw) 2016-08-23 01:29:56 PDT 
Committed r204779: <http://trac.webkit.org/changeset/204779>