Bug 160996 - WebRTC: [GTK] Improve video element MediaStream player to support more advanced test cases
Summary: WebRTC: [GTK] Improve video element MediaStream player to support more advanc...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 143211
  Show dependency treegraph
Reported: 2016-08-19 04:53 PDT by Adam Bergkvist
Modified: 2017-01-29 22:50 PST (History)
6 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-08-19 04:53:35 PDT
At the time of writing, the three tests below are skipped.

Comment 1 Adam Bergkvist 2016-10-07 03:10:36 PDT
Updated list

webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html [ Skip ]
webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ Skip ]
webkit.org/b/160996 fast/mediastream/apply-constraints-advanced.html [ Skip ]
webkit.org/b/160996 fast/mediastream/apply-constraints-audio.html [ Skip ]
webkit.org/b/160996 fast/mediastream/apply-constraints-video.html [ Skip ]
Comment 2 Carlos Alberto Lopez Perez 2017-01-17 17:09:13 PST
I think is better to mark tests as failing or timing out rather than just skip them.

Otherwise when any of the following happens:

 * Some revision introduces a regression that makes the test crash
 * Some revision makes the test pass

It goes completely undetected.

A real example.. I'm checking that now, of the 5 mediastream tests skipped assigned to this bug, 2 are working now. And nobody was aware of that.

If those 5 test were marked as failing, the bots would notice the new passes.

But with skipped tests nobody notices.
Comment 3 Carlos Alberto Lopez Perez 2017-01-17 17:13:32 PST
Current status:

Regressions: Unexpected image-only failures (1)
  fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ ImageOnlyFailure ]

Regressions: Unexpected timeouts (1)
  fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html [ Timeout ]
Comment 4 Carlos Alberto Lopez Perez 2017-01-17 17:36:48 PST
Done: unskipped all the MediaStream tests and instead marked the ones still failing or timing out as such in r210838: <http://trac.webkit.org/changeset/210838>