The check-webkit-style script treats lambda functions as regular C++ functions from a style perspective, which is incorrect.
Created attachment 286204 [details] Patch
Comment on attachment 286204 [details] Patch hooray!
Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?
(In reply to comment #3) > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? Looks like they are addressing the same issue. This change was made in more places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, it's following the same pattern as if, else and while, among others. It also flags cases such as: [var1 , var2], [ & ] and [ ]. https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be interested how it does with the tests in this patch.
(In reply to comment #4) > (In reply to comment #3) > > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? > > Looks like they are addressing the same issue. This change was made in more > places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, > it's following the same pattern as if, else and while, among others. > > It also flags cases such as: [var1 , var2], [ & ] and [ ]. > > https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be > interested how it does with the tests in this patch. I didn't really mean is that patch the same as this patch - That patch was long ago abandoned. I meant that this bug is a dupe of that bug.
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > ... > > > > ... > > I didn't really mean is that patch the same as this patch - That patch was > long ago abandoned. > > I meant that this bug is a dupe of that bug. Yeah, I just looked at the date on that. Somehow I missed it. And yes, this would be a duplicate of that.
Comment on attachment 286204 [details] Patch Clearing flags on attachment: 286204 Committed r204723: <http://trac.webkit.org/changeset/204723>
All reviewed patches have been landed. Closing bug.
*** Bug 125616 has been marked as a duplicate of this bug. ***