Bug 160910 – check-webkit-style does not work with Lambda functions in C++

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

The check-webkit-style script treats lambda functions as regular C++ functions from a style perspective, which is incorrect.

[Jonathan Bedard]

Created attachment 286204 [details]
Patch

[Alex Christensen]

Comment on attachment 286204 [details]
Patch

hooray!

[Brady Eidson]

Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?

[Jonathan Bedard]

(In reply to comment #3)
> Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?

Looks like they are addressing the same issue.  This change was made in more places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, it's following the same pattern as if, else and while, among others.

It also flags cases such as: [var1 , var2], [ & ] and [ ].

https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be interested how it does with the tests in this patch.

[Brady Eidson]

(In reply to comment #4)
> (In reply to comment #3)
> > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?
> 
> Looks like they are addressing the same issue.  This change was made in more
> places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616,
> it's following the same pattern as if, else and while, among others.
> 
> It also flags cases such as: [var1 , var2], [ & ] and [ ].
> 
> https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be
> interested how it does with the tests in this patch.

I didn't really mean is that patch the same as this patch - That patch was long ago abandoned.

I meant that this bug is a dupe of that bug.

[Jonathan Bedard]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > ...
> > 
> > ...
>
> I didn't really mean is that patch the same as this patch - That patch was
> long ago abandoned.
> 
> I meant that this bug is a dupe of that bug.

Yeah, I just looked at the date on that.  Somehow I missed it.  And yes, this would be a duplicate of that.

[WebKit Commit Bot]

Comment on attachment 286204 [details]
Patch

Clearing flags on attachment: 286204

Committed r204723: <http://trac.webkit.org/changeset/204723>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

*** Bug 125616 has been marked as a duplicate of this bug. ***