Bug 160910 - check-webkit-style does not work with Lambda functions in C++
Summary: check-webkit-style does not work with Lambda functions in C++
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 125616 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-16 14:11 PDT by Jonathan Bedard
Modified: 2016-08-26 09:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2016-08-16 14:31 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2016-08-16 14:11:41 PDT
The check-webkit-style script treats lambda functions as regular C++ functions from a style perspective, which is incorrect.
Comment 1 Jonathan Bedard 2016-08-16 14:31:29 PDT
Created attachment 286204 [details]
Patch
Comment 2 Alex Christensen 2016-08-16 16:36:25 PDT
Comment on attachment 286204 [details]
Patch

hooray!
Comment 3 Brady Eidson 2016-08-16 16:49:30 PDT
Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?
Comment 4 Jonathan Bedard 2016-08-16 17:08:32 PDT
(In reply to comment #3)
> Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?

Looks like they are addressing the same issue.  This change was made in more places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, it's following the same pattern as if, else and while, among others.

It also flags cases such as: [var1 , var2], [ & ] and [ ].

https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be interested how it does with the tests in this patch.
Comment 5 Brady Eidson 2016-08-16 17:11:30 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ?
> 
> Looks like they are addressing the same issue.  This change was made in more
> places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616,
> it's following the same pattern as if, else and while, among others.
> 
> It also flags cases such as: [var1 , var2], [ & ] and [ ].
> 
> https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be
> interested how it does with the tests in this patch.

I didn't really mean is that patch the same as this patch - That patch was long ago abandoned.

I meant that this bug is a dupe of that bug.
Comment 6 Jonathan Bedard 2016-08-16 17:14:29 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > ...
> > 
> > ...
>
> I didn't really mean is that patch the same as this patch - That patch was
> long ago abandoned.
> 
> I meant that this bug is a dupe of that bug.

Yeah, I just looked at the date on that.  Somehow I missed it.  And yes, this would be a duplicate of that.
Comment 7 WebKit Commit Bot 2016-08-22 09:42:31 PDT
Comment on attachment 286204 [details]
Patch

Clearing flags on attachment: 286204

Committed r204723: <http://trac.webkit.org/changeset/204723>
Comment 8 WebKit Commit Bot 2016-08-22 09:42:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Jonathan Bedard 2016-08-26 09:13:03 PDT
*** Bug 125616 has been marked as a duplicate of this bug. ***