Bug 125616 - check-webkit-style is wrong about style for C++11 lambdas
Summary: check-webkit-style is wrong about style for C++11 lambdas
Status: RESOLVED DUPLICATE of bug 160910
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 137309 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-11 22:14 PST by Brady Eidson
Modified: 2016-08-26 09:13 PDT (History)
4 users (show)

See Also:

Attachments
The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. (758 bytes, patch)
2013-12-16 14:52 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-12-11 22:14:06 PST 
check-webkit-style is wrong about style for c++11 lambdas

It complains: Place brace on its own line for function definitions.  [whitespace/braces] [4]

An example patch with the correct style is attached to bug https://bugs.webkit.org/show_bug.cgi?id=125258
Comment 1 Brady Eidson 2013-12-16 14:52:01 PST 
Created attachment 219357 [details]
The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines.

Don't have time to add the exception to the coding style guidelines or write a unit test for this, but this is the fix.
Comment 2 Darin Adler 2016-01-31 20:36:05 PST 
*** Bug 137309 has been marked as a duplicate of this bug. ***
Comment 3 Darin Adler 2016-01-31 20:36:32 PST 
Bug 153732 shows one of the many, many cases where the style checker gives false positives about this.
Comment 4 Jonathan Bedard 2016-08-26 09:13:03 PDT 

*** This bug has been marked as a duplicate of bug 160910 ***