ASSIGNED 160825
Web Inspector: Focus on text editor after opening a resource via Open Resource Dialog
https://bugs.webkit.org/show_bug.cgi?id=160825
Summary Web Inspector: Focus on text editor after opening a resource via Open Resourc...
Nikita Vasilyev
Reported 2016-08-12 14:59:20 PDT
Steps: 1. Open Web Inspector on https://webkit.org 2. Press Command-Option-O 3. Type "global.js", press Enter Expected: global.js opens with text caret inside of it, so a person could immediately type or select text. Actual: global.js opens, but it doesn't get focused. Notes: Via https://bugs.webkit.org/show_bug.cgi?id=159732#c8
Attachments
Patch (9.68 KB, patch)
2016-08-12 15:46 PDT, Nikita Vasilyev
nvasilyev: review-
nvasilyev: commit-queue-
Radar WebKit Bug Importer
Comment 1 2016-08-12 14:59:53 PDT
Nikita Vasilyev
Comment 2 2016-08-12 15:46:18 PDT
Nikita Vasilyev
Comment 3 2016-08-12 15:49:03 PDT
Comment on attachment 285965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285965&action=review > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:477 > + Focusing works well for the current resource (e.g. ":100:42") but it still doesn't work for a different resource (e.g. "foo.js:100:42") :-/
Nikita Vasilyev
Comment 4 2016-08-12 22:13:29 PDT
Comment on attachment 285965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285965&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:144 > + contentView.revealPosition(new WebInspector.SourceCodePosition(cookie.lineNumber, cookie.columnNumber), textRangeToSelect, forceUnformatted, shouldFocus); Entering just "foo.js" without line numbers should still focus on the text editor, so I think focusing should NOT be done by contentView.revealPosition. Back to the drawing board.
Note You need to log in before you can comment on or make changes to this bug.