Bug 159732 – Web Inspector: Support for :lineNumber syntax in Open Resource Dialog

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Open Resource Dialog (aka Quick Open) in Sublime Text and Chrome DevTools
support "path/to/file.js:lineNumber" syntax. It would be nice if we had it too.

Steps:
1. Open Web Inspector on this page.
2. Press Cmd-Shift-O.
3. Enter "global.css:200".

Expected:
global.css opens on 200th line.

Actual:
Open Resource Dialog doesn't find any matching files.

[Blaze Burg]

In ST2+, just :nnn will seek to that line within the current text editor.

[Nikita Vasilyev]

Created attachment 285251 [details]
[Animated GIF] ":123" doesn't jump to line 123

(In reply to comment #1)
> In ST2+, just :nnn will seek to that line within the current text editor.

Doesn't work for me.

[Matt Baker]

Similar to Chrome and Sublime, we should also bring up the dialog pre-populated with a ":" when pressing Control-G. Removing the colon should return the dialog to Quick Open mode.

[Radar WebKit Bug Importer]

<rdar://problem/27684491>

[Joseph Pecoraro]

Easy enough to do. Textmate supports all kinds of syntax:

  • basic position ":<line>:<column>"
  • multiple cursors ":10:0&:11:0"
  • ranges ":10:0-:11:0"

But I think for starters basic positions will work fine. I have this working, I just need to clean the code up a bit.

[Joseph Pecoraro]

Created attachment 285881 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 285881 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=285881&action=review

Works great!

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:164
> +                    let [_, lineNumber, columnNumber] = this._inputElement.value.split(":");

Placeholders aren't necessary to ignore destructured return values.

[Nikita Vasilyev]

Comment on attachment 285881 [details]
[PATCH] Proposed Fix

Would be nice to focus on a CodeMirror instance after ":<line>:<column>" query is entered, so I could type right away.

[Joseph Pecoraro]

(In reply to comment #7)
> Comment on attachment 285881 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285881&action=review
> 
> Works great!
> 
> > Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:164
> > +                    let [_, lineNumber, columnNumber] = this._inputElement.value.split(":");
> 
> Placeholders aren't necessary to ignore destructured return values.

Oh snap!

[Joseph Pecoraro]

(In reply to comment #8)
> Comment on attachment 285881 [details]
> [PATCH] Proposed Fix
> 
> Would be nice to focus on a CodeMirror instance after ":<line>:<column>"
> query is entered, so I could type right away.

I agree and almost tackled it with this patch. In the end, focusing is a more generic problem that I think could be handled in a separate patch. Maybe its as easy as adding a field to the cookie (alongside lineNumber/columnNumber) or maybe showing text content views should always focus when shown.

[Joseph Pecoraro]

Created attachment 285927 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 285927 [details]
[PATCH] For Landing

Clearing flags on attachment: 285927

Committed r204418: <http://trac.webkit.org/changeset/204418>

[Nikita Vasilyev]

Closing manually. I don't know why it didn't get closed after committing.