Bug 160669 - "ValueError: insecure string pickle" running webkitpy tests
Summary: "ValueError: insecure string pickle" running webkitpy tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-08 15:09 PDT by Simon Fraser (smfr)
Modified: 2016-08-08 17:59 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-08-08 15:09:34 PDT
233$ $ ./Tools/Scripts/test-webkitpy 
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

[162/1454] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_bad_command erred:                               
  Traceback (most recent call last):
    File "/Volumes/Data/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 109, in test_run_command_with_bad_command
      self.assertRaises(OSError, run_bad_command)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 475, in assertRaises
      callableObj(*args, **kwargs)
    File "/Volumes/Data/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 108, in run_bad_command
      Executive().run_command(["foo_bar_command_blah"], error_handler=Executive.ignore_error, return_exit_code=True)
    File "/Volumes/Data/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in run_command
      close_fds=self._should_close_fds())
    File "/Volumes/Data/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py", line 528, in popen
      return subprocess.Popen(string_args, **kwargs)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
      errread, errwrite)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1334, in _execute_child
      child_exception = pickle.loads(data)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 1382, in loads
      return Unpickler(file).load()
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 858, in load
      dispatch[key](self)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/pickle.py", line 966, in load_string
      raise ValueError, "insecure string pickle"
  ValueError: insecure string pickle
  
Ran 1454 tests in 4.915s                                                                                                                   
FAILED (failures=0, errors=1)
Comment 1 Simon Fraser (smfr) 2016-08-08 15:12:23 PDT
 235$ $ python --version
Python 2.7.10
on an El Capitan-era build.
Comment 2 Alexey Proskuryakov 2016-08-08 17:59:30 PDT
Bots are not seeing this.