Bug 160649 – Node.baseURI should not be nullable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Node.baseURI should not be nullable as per the latest DOM specification:
- https://dom.spec.whatwg.org/#dom-node-baseuri

It is not nullable in Firefox. It is supposed to fallback to using the document's URL.

[Chris Dumez]

Created attachment 285538 [details]
Patch

[Darin Adler]

Comment on attachment 285538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285538&action=review

OK, but seems a little messy.

> Source/WebCore/dom/Node.h:165
> +    const URL& baseURI() const;
> +    const URL& baseURIForBindings() const;

What is the code that still needs to use the old Node::baseURI function? I don’t think we should be keeping it around.

> LayoutTests/imported/w3c/ChangeLog:13
> +        is still failing. We are failling back to using the document's URL, as expected.

typo: "failling"

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 285538 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285538&action=review
> 
> OK, but seems a little messy.
> 
> > Source/WebCore/dom/Node.h:165
> > +    const URL& baseURI() const;
> > +    const URL& baseURIForBindings() const;
> 
> What is the code that still needs to use the old Node::baseURI function? I
> don’t think we should be keeping it around.
> 
> > LayoutTests/imported/w3c/ChangeLog:13
> > +        is still failing. We are failling back to using the document's URL, as expected.
> 
> typo: "failling"

Ok, I see if I can make this a bit cleaner.

[Chris Dumez]

Created attachment 285544 [details]
Patch

[Build Bot]

Comment on attachment 285544 [details]
Patch

Attachment 285544 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1831699

New failing tests:
fast/filter-image/filter-image-blur.html

[Build Bot]

Created attachment 285549 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 285544 [details]
Patch

Attachment 285544 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1831703

New failing tests:
fast/filter-image/filter-image-blur.html

[Build Bot]

Created attachment 285550 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 285544 [details]
Patch

Attachment 285544 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1831702

New failing tests:
fast/filter-image/filter-image-blur.html

[Build Bot]

Created attachment 285551 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Build Bot]

Comment on attachment 285544 [details]
Patch

Attachment 285544 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1831704

New failing tests:
fast/filter-image/filter-image-blur.html

[Build Bot]

Created attachment 285552 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 285554 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285554 [details]
Patch

Clearing flags on attachment: 285554

Committed r204247: <http://trac.webkit.org/changeset/204247>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.