Bug 160660 - Update API tests in mac/SetDocumentURI.mm after r204247
Summary: Update API tests in mac/SetDocumentURI.mm after r204247
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 160649
  Show dependency tree / graph
 
Reported: 2016-08-08 09:26 PDT by Ryan Haddad
Modified: 2016-08-08 10:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2016-08-08 09:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-08-08 09:26:25 PDT 
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/16963/steps/run-api-tests/logs/stdio

FAIL WebKit1.SetDocumentURITestNull

/Volumes/Data/slave/yosemite-release/build/Tools/TestWebKitAPI/Tests/mac/SetDocumentURI.mm:118
Value of: [document baseURI]
  Actual: "about:blank"
Expected: @""
Which is: ""

FAIL WebKit1.SetDocumentURITestString

/Volumes/Data/slave/yosemite-release/build/Tools/TestWebKitAPI/Tests/mac/SetDocumentURI.mm:101
Value of: [document baseURI]
  Actual: "about:blank"
Expected: @""
Which is: ""
Comment 1 Ryan Haddad 2016-08-08 09:27:11 PDT 
Tests started failing after http://trac.webkit.org/changeset/204247 changed the baseURI to "about:blank"
Comment 2 Chris Dumez 2016-08-08 09:40:33 PDT 
Oh, I'll fix, thanks.
Comment 3 Chris Dumez 2016-08-08 09:43:00 PDT 
Created attachment 285568 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-08 10:25:44 PDT 
Comment on attachment 285568 [details]
Patch

Clearing flags on attachment: 285568

Committed r204256: <http://trac.webkit.org/changeset/204256>
Comment 5 WebKit Commit Bot 2016-08-08 10:25:49 PDT 
All reviewed patches have been landed.  Closing bug.