Bug 160510 – LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Ryan Haddad]

LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky

Crash:
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r204079%20(8190)/results.html

Failure:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204075%20(7134)/results.html

Flakiness dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Ffetch%2Ffetch-in-worker-crash.html

Thread 26 Crashed:: WebCore: Worker
0   com.apple.WebCore             	0x00000001095bf3bf WebCore::WorkerThreadableLoader::MainThreadBridge::cancel() + 335 (WorkerThreadableLoader.cpp:159)
1   com.apple.WebCore             	0x000000010881a8dd WebCore::FetchResponse::stop() + 221 (FetchResponse.cpp:300)
2   com.apple.WebCore             	0x000000010925ffe7 WebCore::ScriptExecutionContext::stopActiveDOMObjects() + 343 (ScriptExecutionContext.cpp:298)
3   com.apple.WebCore             	0x00000001095be730 WTF::Function<void (WebCore::ScriptExecutionContext&)>::CallableWrapper<WebCore::WorkerThread::stop()::$_0>::call(WebCore::ScriptExecutionContext&) + 32 (Function.h:101)
4   com.apple.WebCore             	0x00000001095bb5b3 WebCore::WorkerRunLoop::runCleanupTasks(WebCore::WorkerGlobalScope*) + 211 (memory:2459)
5   com.apple.WebCore             	0x00000001095bb2bf WebCore::WorkerRunLoop::run(WebCore::WorkerGlobalScope*) + 111 (WorkerRunLoop.cpp:134)
6   com.apple.WebCore             	0x00000001095be3be WebCore::WorkerThread::workerThread() + 718 (WorkerThread.cpp:186)
7   com.apple.JavaScriptCore      	0x0000000107e19f52 WTF::threadEntryPoint(void*) + 178 (Threading.cpp:61)
8   com.apple.JavaScriptCore      	0x0000000107e1a36f WTF::wtfThreadEntryPoint(void*) + 15 (ThreadingPthreads.cpp:166)
9   libsystem_pthread.dylib       	0x00007fff8eae399d _pthread_body + 131
10  libsystem_pthread.dylib       	0x00007fff8eae391a _pthread_start + 168
11  libsystem_pthread.dylib       	0x00007fff8eae1351 thread_start + 13


--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/fetch/fetch-in-worker-crash-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/http/tests/fetch/fetch-in-worker-crash-actual.txt
@@ -1,5 +1,5 @@
 CONSOLE MESSAGE: line 11: 0
-CONSOLE MESSAGE: line 11: 1
+CONSOLE MESSAGE: line 11: FAIL: promise 1 resolved
 Test that terminating an ongoing fetch in a worker does not cause a crash.
 
 PASS: No crash.

[youenn fablet]

*** This bug has been marked as a duplicate of bug 160498 ***

[youenn fablet]

Test is less flaky but still flaky. Reopening the bug

[youenn fablet]

Created attachment 285354 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285354 [details]
Patch

Clearing flags on attachment: 285354

Committed r204223: <http://trac.webkit.org/changeset/204223>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This test became much more flaky after this fix, and it still crashes too.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Ffetch%2Ffetch-in-worker-crash.html

https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK1%20(Tests)/r204235%20(7920)/DumpRenderTree-28112-crash-log.txt

Could you please take a look soon? The test is so flaky that it's likely to cause EWS false positives.

[youenn fablet]

Created attachment 285523 [details]
Patch for landing

[youenn fablet]

(In reply to comment #7)
> Created attachment 285523 [details]
> Patch for landing

Marked test as flaky.
I'll investigate why it is flaky in two weeks from now.
From what I see, there is a problem with the readable stream when stopping the loads, that is causing unnecessary JavaScript execution.

[WebKit Commit Bot]

Comment on attachment 285523 [details]
Patch for landing

Clearing flags on attachment: 285523

Committed r204240: <http://trac.webkit.org/changeset/204240>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Reopened to fix issue with ReadableStream.

[youenn fablet]

Created attachment 286573 [details]
Fixing failure flakiness

[WebKit Commit Bot]

Comment on attachment 286573 [details]
Fixing failure flakiness

Clearing flags on attachment: 286573

Committed r204704: <http://trac.webkit.org/changeset/204704>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.