RESOLVED FIXED 160485
Web Inspector: Add placeholder graphs to TimelineOverview while editing 
https://bugs.webkit.org/show_bug.cgi?id=160485
Summary Web Inspector: Add placeholder graphs to TimelineOverview while editing
Matt Baker
Reported 2016-08-02 18:22:46 PDT
In order for timeline drag and drop to work (https://bugs.webkit.org/show_bug.cgi?id=157957), each placeholder tree item needs a corresponding placeholder element in the graph container.
Attachments
[Image] Network graph w/ four placeholder graphs (184.72 KB, image/png)
2016-08-02 18:27 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (3.63 KB, patch)
2016-08-02 18:34 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] UI w/o alternating graph styles (179.29 KB, image/png)
2016-08-03 13:32 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (3.43 KB, patch)
2016-08-03 13:38 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-02 18:23:39 PDT
<rdar://problem/27670755>
Matt Baker
Comment 2 2016-08-02 18:27:33 PDT
Created attachment 285178 [details] [Image] Network graph w/ four placeholder graphs
Matt Baker
Comment 3 2016-08-02 18:34:22 PDT
Created attachment 285180 [details] [Patch] Proposed Fix
Blaze Burg
Comment 4 2016-08-03 09:53:36 PDT
Comment on attachment 285180 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=285180&action=review The change looks fine, but I don't understand why it's necessary. Can you please put more "why" into the changelog? > Source/WebInspectorUI/ChangeLog:16 > +2016-08-02 Matt Baker <mattbaker@apple.com> Nit: Double changelog.
Matt Baker
Comment 5 2016-08-03 13:32:42 PDT
Created attachment 285265 [details] [Image] UI w/o alternating graph styles
Matt Baker
Comment 6 2016-08-03 13:35:16 PDT
This patch does two things: 1) allows the alternating graph styles to be shown for the inactive instruments 2) when a instrument is dragged/reordered the tree item and graph move together
Matt Baker
Comment 7 2016-08-03 13:38:40 PDT
Created attachment 285266 [details] [Patch] Proposed Fix
Blaze Burg
Comment 8 2016-08-04 10:29:05 PDT
Comment on attachment 285266 [details] [Patch] Proposed Fix r=me
WebKit Commit Bot
Comment 9 2016-08-04 10:50:00 PDT
Comment on attachment 285266 [details] [Patch] Proposed Fix Clearing flags on attachment: 285266 Committed r204125: <http://trac.webkit.org/changeset/204125>
WebKit Commit Bot
Comment 10 2016-08-04 10:50:04 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 11 2016-08-10 23:34:37 PDT
Heck yes! Nice, I've been wanting this for a while!
Note You need to log in before you can comment on or make changes to this bug.