Bug 157957 - Web Inspector: allow reordering of timelines via drag and drop in edit mode
Summary: Web Inspector: allow reordering of timelines via drag and drop in edit mode
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 160485
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-20 15:12 PDT by BJ Burg
Modified: 2016-12-13 15:32 PST (History)
3 users (show)

See Also:


Attachments
[Video] New UI (297.18 KB, video/mp4)
2016-05-21 14:44 PDT, Matt Baker
no flags Details
[Video] New UI - reorder timelines (272.30 KB, video/mp4)
2016-05-22 14:50 PDT, Matt Baker
no flags Details
[Video] Updated UI (528.59 KB, video/mp4)
2016-08-08 13:21 PDT, Matt Baker
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-20 15:12:09 PDT
I am so sick of having layout be above JavaScript! :)
Comment 1 Radar WebKit Bug Importer 2016-05-20 15:13:17 PDT
<rdar://problem/26400473>
Comment 2 Matt Baker 2016-05-20 18:31:13 PDT
Yes! I've been dying to do this for a while. Will have something up tonight or tomorrow morning.
Comment 3 Matt Baker 2016-05-21 14:44:22 PDT
Created attachment 279545 [details]
[Video] New UI

Added edit transition and move handles for the tree elements.
Comment 4 Timothy Hatcher 2016-05-21 19:12:46 PDT
Cool! Only suggestion, use: cursor: row-resize; for the drag handle.
Comment 5 Matt Baker 2016-05-22 14:50:31 PDT
Created attachment 279553 [details]
[Video] New UI - reorder timelines

Draggable tree items. Borders for tree items adjacent to the "hole" left by the item being dragged still need work.
Comment 6 BJ Burg 2016-08-01 11:39:13 PDT
Matt, are you ready to put this up for review?
Comment 7 Matt Baker 2016-08-08 13:21:03 PDT
Created attachment 285583 [details]
[Video] Updated UI

Improvements:
- Dragging a tree element moves the corresponding graph
- Checkboxes slide in from right, animate x-coordinate and opacity
- Sped up transition to/from Edit mode to 200ms

Need to address an issue with dragging oversize timelines (Memory) before posting a PFR.
Comment 8 BJ Burg 2016-09-14 16:38:04 PDT
(In reply to comment #7)
> Created attachment 285583 [details]
> [Video] Updated UI
> 
> Improvements:
> - Dragging a tree element moves the corresponding graph
> - Checkboxes slide in from right, animate x-coordinate and opacity
> - Sped up transition to/from Edit mode to 200ms
> 
> Need to address an issue with dragging oversize timelines (Memory) before
> posting a PFR.

What happened to this patch?