Bug 160478 – Make -webkit-transition-* and -webkit-animation-* properties be pure aliases of the unprefixed ones

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

<rdar://problem/27668058>

[Alexey Proskuryakov]

Is this the root cause for bug 161254?

[Simon Fraser (smfr)]

*** Bug 161831 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

The problem is that this no longer works:

            transition: background-color 1s;
            transition-delay: 1s;

(same for animations).

CSSParser::parseTransitionShorthand() also sets prefixed properties, but parsing the longhands does not, so we behave as if -webkit-transition-delay:0 is set. Indeed, changing the second line to -webkit-transition-delay: 1s works around the bug.

[Simon Fraser (smfr)]

Created attachment 288501 [details]
Patch

[Build Bot]

Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2049550

New failing tests:
transitions/svg-transitions.html
svg/css/getComputedStyle-basic.xhtml

[Build Bot]

Created attachment 288505 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2049598

New failing tests:
svg/css/getComputedStyle-basic.xhtml
transitions/svg-transitions.html

[Build Bot]

Created attachment 288506 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2049609

New failing tests:
svg/css/getComputedStyle-basic.xhtml
transitions/svg-transitions.html

[Build Bot]

Created attachment 288507 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

Created attachment 288508 [details]
Patch

[Simon Fraser (smfr)]

Dean or Antoine should confirm that this is the right thing to do.

[Dean Jackson]

Comment on attachment 288508 [details]
Patch

Wish we'd done this from the start!

[Simon Fraser (smfr)]

Comment on attachment 288508 [details]
Patch

OK then!

[WebKit Commit Bot]

Comment on attachment 288508 [details]
Patch

Clearing flags on attachment: 288508

Committed r205809: <http://trac.webkit.org/changeset/205809>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

Oh yeah, this looks so much better.