Bug 160478 - Make -webkit-transition-* and -webkit-animation-* properties be pure aliases of the unprefixed ones
Summary: Make -webkit-transition-* and -webkit-animation-* properties be pure aliases ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
: 161831 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-02 16:39 PDT by Dean Jackson
Modified: 2016-09-12 10:28 PDT (History)
9 users (show)

See Also:

Attachments
Patch (56.49 KB, patch)
2016-09-10 14:48 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.37 MB, application/zip)
2016-09-10 15:42 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (875.37 KB, application/zip)
2016-09-10 15:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.51 MB, application/zip)
2016-09-10 15:58 PDT, Build Bot 		no flags Details
Patch (61.52 KB, patch)
2016-09-10 16:02 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-08-02 16:39:26 PDT 
<rdar://problem/27668058>
Comment 1 Alexey Proskuryakov 2016-08-26 11:21:40 PDT 
Is this the root cause for bug 161254?
Comment 2 Simon Fraser (smfr) 2016-09-09 21:10:30 PDT 
*** Bug 161831 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2016-09-09 21:12:06 PDT 
The problem is that this no longer works:

            transition: background-color 1s;
            transition-delay: 1s;

(same for animations).

CSSParser::parseTransitionShorthand() also sets prefixed properties, but parsing the longhands does not, so we behave as if -webkit-transition-delay:0 is set. Indeed, changing the second line to -webkit-transition-delay: 1s works around the bug.
Comment 4 Simon Fraser (smfr) 2016-09-10 14:48:13 PDT 
Created attachment 288501 [details]
Patch
Comment 5 Build Bot 2016-09-10 15:42:41 PDT 
Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2049550

New failing tests:
transitions/svg-transitions.html
svg/css/getComputedStyle-basic.xhtml
Comment 6 Build Bot 2016-09-10 15:42:46 PDT 
Created attachment 288505 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-09-10 15:49:16 PDT 
Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2049598

New failing tests:
svg/css/getComputedStyle-basic.xhtml
transitions/svg-transitions.html
Comment 8 Build Bot 2016-09-10 15:49:20 PDT 
Created attachment 288506 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-09-10 15:58:02 PDT 
Comment on attachment 288501 [details]
Patch

Attachment 288501 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2049609

New failing tests:
svg/css/getComputedStyle-basic.xhtml
transitions/svg-transitions.html
Comment 10 Build Bot 2016-09-10 15:58:05 PDT 
Created attachment 288507 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Simon Fraser (smfr) 2016-09-10 16:02:23 PDT 
Created attachment 288508 [details]
Patch
Comment 12 Simon Fraser (smfr) 2016-09-11 09:39:03 PDT 
Dean or Antoine should confirm that this is the right thing to do.
Comment 13 Dean Jackson 2016-09-11 16:47:05 PDT 
Comment on attachment 288508 [details]
Patch

Wish we'd done this from the start!
Comment 14 Simon Fraser (smfr) 2016-09-12 08:31:21 PDT 
Comment on attachment 288508 [details]
Patch

OK then!
Comment 15 WebKit Commit Bot 2016-09-12 08:52:22 PDT 
Comment on attachment 288508 [details]
Patch

Clearing flags on attachment: 288508

Committed r205809: <http://trac.webkit.org/changeset/205809>
Comment 16 WebKit Commit Bot 2016-09-12 08:52:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 17 Antoine Quint 2016-09-12 10:28:14 PDT 
Oh yeah, this looks so much better.